| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 13:00:43 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/207
server-timing: nginx;desc="NGINX";dur=1.276418,glb;desc="GLB";dur=95.519427
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=mLOz2r9xPCB%2B3jgMLVGAVbVSjm5Q2HTH%2BCqeIwlHcPcq4hPy34ddhX7jbiY7N9Yb1lX2STGVFMtARfQEA53lK%2FX6OZQwH8tlsd%2F9lNr5dV%2BcXpKy0LVZgFYYX7VSVyU%2F3G5%2B4JhdS676n3Aoi2mUcwnisIqmyI7wd2qOf7IsBbmpATrixaZj2%2FZ8wxGuqH6eacmnKsczM3uUKZY3KtG%2FqMxqXdgvgYEYyVoRP23TbCyrYGHaknoJRQnbpMYS4KeoguVU0m%2B3PqwqfO%2FoeFlKRQ%3D%3D--0RP%2F5l9QV2%2FFaDSm--e%2FNkJ1J87uyLuYz6MzHTCw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1890641851.1752584443; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 13:00:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 13:00:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 91D2:18B7F5:91963A:A38D06:687650FB
HTTP/2 200
date: Tue, 15 Jul 2025 13:00:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=384.880681,conversation_content-fragment;desc="conversation_content fragment";dur=596.563915,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=304.418779,nginx;desc="NGINX";dur=0.953665,glb;desc="GLB";dur=96.098779
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 91D2:18B7F5:9196B4:A38D78:687650FB
Sync nsd-control-setup with unbound-control-setup to generate certificates with SANs by sbiberhofer · Pull Request #207 · NLnetLabs/nsd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
Sync nsd-control-setup with unbound-control-setup to generate certificates with SANs #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
sbiberhofer:feature/nsd-control-setup-add-san
Feb 7, 2022
Merged
Sync nsd-control-setup with unbound-control-setup to generate certificates with SANs #207
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
sbiberhofer:feature/nsd-control-setup-add-san
Feb 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make nsd-control-setup add x509v3 SAN extensions to generated certificates by essentially syncing this script with unbound's unbound-control-setup, which already includes these extensions in generated certificates. Signed-off-by: Sascha Biberhofer <sascha.biberhofer@skyforge.at>
wcawijngaards
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good and match unbound's version.
wcawijngaards
added a commit
that referenced
this pull request
Feb 7, 2022
- Merge #207 Sync nsd-control-setup with unbound-control-setup to generate certificates with SANs.
|
Thanks for the patch! It is a good idea to also have those fixes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Right now
nsd-control-setupgenerates very simple certificates which do not contain a SAN attribute. This is particularly problematic for tools likensd_exporter, which requires SANs when compiled with recent versions of Go.Since this has already been fixed in unbound's version of this script, this PR basically syncs
nsd-control-setupwithunbound-control-setupto fix this issue in what I hope is the simplest possible way. Aside from adding the necessary extensions, this also extends certificate lifetime.