| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 21:04:39 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/187
server-timing: nginx;desc="NGINX";dur=0.893262,glb;desc="GLB";dur=395.674334
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=IjEXRKey2yan%2BMEPtpGGc4HvEhrWdXaaHEHu08vzjMq0r9gLk8gyh9gh9p3YHzCr1OTXBwVKYu%2BM7zoeez%2FplbHsMV5pDphHIXVB5ESuRtY1iv6iFXJ7yRBwwFhGNbc9rD%2F%2BzvNWKaAjs9UeaNS6LhItf%2BaqBB7MwnMHevctYOFVnxWG5VR9CXuyxnueN0fNkOD9eoT4sksTQ%2FgPaz33UcXyY%2BkRhAY1x%2FoVPRIE9FOFKr5c06VGpMxxJqDnjJcNtlNl5exEBMTjc22REKv7jg%3D%3D--q7%2Fm3QktVkIpHV3q--Nz%2Fa0Ro%2FmeSyyeKmBLjK5A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2129320474.1752613478; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 21:04:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 21:04:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9908:590D1:157A1C:1BCFF2:6876C266
HTTP/2 200
date: Tue, 15 Jul 2025 21:04:40 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=303.719986,conversation_content-fragment;desc="conversation_content fragment";dur=567.700248,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=232.998768,nginx;desc="NGINX";dur=1.468627,glb;desc="GLB";dur=101.174733
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 9908:590D1:157A50:1BD03D:6876C266
- Support using system-wide crypto policies by paulwouters · Pull Request #187 · NLnetLabs/nsd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
- Support using system-wide crypto policies #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
paulwouters:system-crypto-policies
Aug 13, 2021
Merged
- Support using system-wide crypto policies #187
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
paulwouters:system-crypto-policies
Aug 13, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System Wide crypto policies are supported via crypto libraries (openssl, NSS, gnutls) on various distros (RHEL, CentOS, Fedora) By not manually calling SSL_CTX_set_cipher_list(), the system-wide crypto policies would be used instead. System-wide crypto policies are detected via the presence of the file /etc/crypto-policies/config
|
note that for example, when the system is running in FIPS mode, the crypto policies would not allow CHACHA20 which is currently being set by nsd. By using the system-wide crypto policies when available, these issues go away. |
wcawijngaards
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to automatically detect what the correct settings are.
wcawijngaards
added a commit
that referenced
this pull request
Aug 13, 2021
|
Thank you for the fix. The detect is very nice, and I also ported it to unbound for a fix to its cipher list. That cipher list was not as restrictive as this one, so the fix is nice anyway. Unbound also allows the cipher list to be set in config, for the public facing endpoints. |
|
For unbound, I had fixed it differently, by just setting it directly in the unbound.conf file we ship. But see this discussion: https://gitlab.com/redhat-crypto/fedora-crypto-policies/-/issues/32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
System Wide crypto policies are supported via crypto libraries
(openssl, NSS, gnutls) on various distros (RHEL, CentOS, Fedora)
By not manually calling SSL_CTX_set_cipher_list(), the system-wide
crypto policies would be used instead.
System-wide crypto policies are detected via the presence of the
file /etc/crypto-policies/config