| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 08:47:08 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/153
server-timing: nginx;desc="NGINX";dur=0.840735,glb;desc="GLB";dur=107.754849
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=c4dMRyNPFoFdzrf%2FGRVmS6Cs0PTDBYkFh%2B%2BARp7CsoxYQ%2FNfxcsIfj3LHJTG1LnhSFjFrfUZmzUXLH8ODF90kXOMHXyEDbUNYtP8IAHlVMnb%2B%2FboARGmx8aYyruxuIIBmPYx5RQ5FP7yRD7HAuETPZkmwPvGk5BGL1PiPqJdeLfufybB9%2F7eDfp6U7%2BJ93QwKf7HWsAW1OLDu%2BZRJdfJl0bZZ2Co6oEPqEg0WGcazRdr3FtURVhQleUpd%2BlCVuuONrvY68k%2BJ8QSCQjdXBq6QQ%3D%3D--n0A58GfOWHD2%2FIru--oT5EjWxsr4M5W%2Fj0uol56w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1919230501.1752569228; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:47:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:47:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C986:2CFD6A:4ACC90:54E51C:6876158C
HTTP/2 200
date: Tue, 15 Jul 2025 08:47:09 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=430.097307,conversation_content-fragment;desc="conversation_content fragment";dur=534.471404,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=310.313139,nginx;desc="NGINX";dur=1.789128,glb;desc="GLB";dur=102.209078
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: C986:2CFD6A:4ACCF6:54E59C:6876158C
Repair -fno-common linker errors automatically. by fobser · Pull Request #153 · NLnetLabs/nsd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
Repair -fno-common linker errors automatically. #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer C compilers are moving towards -fno-common by default (gcc10, clang11). This results in linker errors when symbols collide. nsd contains two yacc parsers, one for the config file, one for zone files resulting in duplicated lex/yacc symbols. Instead of trying to repair this with hand-maintained preprocessor defines use the -P/-p options of flex/yacc to let them do the renaming for us.
|
I've also tried this on OpenBSD with clang10 with option -fno-common and on fedora33 with clang11. |
wcawijngaards
added a commit
that referenced
this pull request
Feb 4, 2021
- Merge PR #153 from fobser: Repair -fno-common linker errors automatically.
|
Thanks for the patch! That looks like nice options to solve this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Newer C compilers are moving towards -fno-common by default (gcc10, clang11).
This results in linker errors when symbols collide.
nsd contains two yacc parsers, one for the config file, one for zone
files resulting in duplicated lex/yacc symbols.
Instead of trying to repair this with hand-maintained preprocessor
defines use the -P/-p options of flex/yacc to let them do the
renaming for us.