| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 08:41:05 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/145
server-timing: nginx;desc="NGINX";dur=1.051998,glb;desc="GLB";dur=100.984038
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=RN0QvLiFocaIaIV0dr9obj69EOlG6wEXYWPJeBte7CcsZGn1m7m7ac0u45W5O5nydk5d6w0A7c3fQv52f2nQJvVjVVCrsJ9VydhXrokHJvCyCvCBqinAMUtupxZblPwaZJTjv3PQuYx5Jm8vDQzmfyOzQNxUDUoYFtPzq1RNmD0xh%2F%2FSxXWczbKaG3g%2ByCC3ctIXSmgK2qIGcATrmzz1hK5%2BCJwj2LtCSVm7CWPLwhUYWZHNpXIIxnlDZUcnNENT8JhiPbjWTKFsGbpBU8hTXw%3D%3D--N1rjCHCSq%2FtfaGNJ--LYK8piMs0P7TJuag8fK%2FSA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1077686758.1752568865; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:41:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:41:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: ACFA:1B37C1:49B21D:53B335:68761421
HTTP/2 200
date: Tue, 15 Jul 2025 08:41:06 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=297.148341,conversation_content-fragment;desc="conversation_content fragment";dur=546.194369,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=261.055974,nginx;desc="NGINX";dur=1.543183,glb;desc="GLB";dur=112.150127
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: ACFA:1B37C1:49B286:53B3AC:68761421
Add support for connection re-use by secondary for XFR by saradickinson · Pull Request #145 · NLnetLabs/nsd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
Add support for connection re-use by secondary for XFR #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saradickinson
wants to merge
10
commits into
NLnetLabs:master
Choose a base branch
from
ShivanKaul:conn_reuse
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logging
…ow. Option not yet used.
…e checkconf unit test to support new options
wcawijngaards
added a commit
that referenced
this pull request
Dec 3, 2020
does not allow new queries to be made, the connection is closed. Only existing queries and zone transfers are answered, new ones are rejected by a close of the channel.
|
Instead of the |
|
I think having the default on would be good, I thought an option might be useful so it could be disabled in case of interop problems (e.g a legacy XFR implementation behind a proxy). |
|
Perhaps it should be configurable per upstream then? For example in the tls-auth: declaration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
*** FOR REVIEW ONLY AT THIS TIME***
xfrd-conn-reuse(default no) andtcp-idle-timeout(default 10)xfrd-conn-reuse: yesthe secondary will utilise the existing the mechanisms in place (which are currently only used whenXFRD_MAX_TCPis exhausted) to re-use connectionstcp-idle-timeout, which is currently a fixed timeout. A later commit will add support for EDNS0 Keepalive, so the server can signal the timeout to use (as described in draft-ietf-dprive-xfr-over-tls)tpkg\long\testplan-axfr.dirtest, will send separate email about this.