You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59907d9 is also referenced for this PR.
Thanks for the code, it is imported in the code repository. Some changes are made to fix a couple of issues and tidy things up a bit.
Thank you for the proof-of-concept code! I pulled in most of it and adjusted it a bit. Fixed too short buffer size problem in the xrealloc calls of resolve_ifa_name, and removed use of strncat, using snprintf instead. Also it now supports @port and the device, fib options with interface the names. Tested that code is portable for Linux, FreeBSD and OSX.
- Merged PR #113 with fixes. Instead of listing an IP-address to
listen on, an interface name can be specified in nsd.conf, with
ip-address: eth0. The IP-addresses for that interface are then used.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
Make it possible to use a network interface name for the
ip-address
configuration key.Rational
Not having to hardcode IP addresses (v4 and v6) in each NSD configuration file.
E.g.
State
The code of this patch is a proof of concept.