CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 12:54:11 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=349.665385,conversation_content-fragment;desc="conversation_content fragment";dur=660.054569,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=319.454601,nginx;desc="NGINX";dur=0.823745,glb;desc="GLB";dur=100.636752
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=GMhSbkoGLJmxANhajWJwPeZDMOZIaImg5M9U51xwT6nZ5QOcFTOj5i1wPicmbyOZC1R93tJYsVTzT4orxfiMuIPO140odMLTYa%2BJimrZtrEhmo8m9tjfzmdWubmzD6gfCEBRQfkbff8flKjGFM%2FC47%2BfdirZ9TsV%2FAQY8SWdy1%2BdC6Og2OGdCeNXBeD%2FIXviDsLSTNSONTxa3GQowvi1mW6n0ZGml0P3YJCdZthI3bwSAKYEAxGJzz48Zu8T1Yxm%2BaFJKwARMiFwl8zZwQG9GQ%3D%3D--g9v%2FP%2B4DKYINkpGc--EuMTrGa4G%2BXixiiYVYOjKg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.164839842.1753966450; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:54:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:54:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A1E6:2C0AA0:A84ACE:C772C9:688B6772
* fixed: libgdx/7212 -- crash when getting value by pointer, affected by GC by dkimitsa · Pull Request #743 · MobiVM/robovm · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 137
* fixed: libgdx/7212 -- crash when getting value by pointer, affected by GC #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tom-Ski
merged 1 commit into
MobiVM:master
from
dkimitsa:fix/libgdx-7212-GC-on-struct-subclass
Sep 2, 2023
Merged
* fixed: libgdx/7212 -- crash when getting value by pointer, affected by GC #743
Tom-Ski
merged 1 commit into
MobiVM:master
from
dkimitsa:fix/libgdx-7212-GC-on-struct-subclass
Sep 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by GC original: libgdx/libgdx#7212 root case: GC code was setting up mark handler only for direct subclass of Struct class to mark its native structure content during GC mark phase. As result memory behind native struct area was release and available for allocations. As result this area was taken by next requested object/data. That caused crashed related to ObjC marshalling, like `objc[503]: Attempt to use unknown class 0x104094d80.` But all pointer extended intermediate classes after Struct: in this case NSErrorPtr->Ptr->Struct Code changed to check for subclass instead direct subclass. Minimal sample to reproduce. ``` void test2() { NSObjectPtr ptr = new NSObjectPtr(); NSObject o = new NSObject(); ptr.set(o); for (int i = 0; i < 100_000_000;i++) { new NSObject(); if (VM.getLong(ptr.getHandle()) != o.getHandle()) { throw new RuntimeException(ptr.getClass() + " " + Long.toHexString(ptr.getHandle()) + "-" + Long.toHexString(VM.getLong(ptr.getHandle()))); } } } ```
6 tasks
Tom-Ski
approved these changes
Sep 2, 2023
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 15, 2024
… by GC (MobiVM#743) original: libgdx/libgdx#7212 root case: GC code was setting up mark handler only for direct subclass of Struct class to mark its native structure content during GC mark phase. As result memory behind native struct area was release and available for allocations. As result this area was taken by next requested object/data. That caused crashed related to ObjC marshalling, like `objc[503]: Attempt to use unknown class 0x104094d80.` But all pointer extended intermediate classes after Struct: in this case NSErrorPtr->Ptr->Struct Code changed to check for subclass instead direct subclass. Minimal sample to reproduce. ``` void test2() { NSObjectPtr ptr = new NSObjectPtr(); NSObject o = new NSObject(); ptr.set(o); for (int i = 0; i < 100_000_000;i++) { new NSObject(); if (VM.getLong(ptr.getHandle()) != o.getHandle()) { throw new RuntimeException(ptr.getClass() + " " + Long.toHexString(ptr.getHandle()) + "-" + Long.toHexString(VM.getLong(ptr.getHandle()))); } } } ``` (cherry picked from commit a94a6b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Source
libgdx/libgdx#7212
root case
GC code was setting up mark handler only for direct subclass of Struct class to mark its native structure content during GC mark phase. As result memory behind native struct area was release and available for allocations. As result this area was taken by next requested object/data. That caused crashed related to ObjC marshalling, like
objc[503]: Attempt to use unknown class 0x104094d80.
But all pointer extended intermediate classes after Struct: in this case NSErrorPtr->Ptr->StructFix
Code changed to check for subclass instead direct subclass.
Minimal sample to reproduce.