CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 12:49:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=367.83793,conversation_content-fragment;desc="conversation_content fragment";dur=545.244977,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=247.455513,nginx;desc="NGINX";dur=1.098735,glb;desc="GLB";dur=100.956754
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=YTUxWMRfPug%2BwygfCuprBq5M16fJudbrZIsbBsZ9eLk5HVt8eSFFGA%2BlQjPsjbFJG8LMwPWCQjwpiBgMRMylqWlXzDo4Xq1N%2BuOzR8vqz3EGuUk0NNRl3ILFlRwzUJWwEWjdkXYkrGwxEKyiy9LxPTOUdIB14VvlWmkIb2gAX62m3P6Hhuy3REtR6UissaVcRUc99%2F19hysj2maPG9R8v3iN21iHIGkohshAY%2F%2FbNg122dfUehSaosByK%2BILuxnf6mffSRvSNK%2BDxTxVfnFXZw%3D%3D--bBQDyIcduOpY6iyS--v38oTp2j1lls9W6rvFzT4w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.783665120.1753966172; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:49:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:49:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EBDC:36DC87:A7187B:C61B08:688B665C
* fixed: strict rules for elements in lists inside robovm.xml by dkimitsa · Pull Request #730 · MobiVM/robovm · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 137
* fixed: strict rules for elements in lists inside robovm.xml #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tom-Ski
merged 3 commits into
MobiVM:master
from
dkimitsa:workaround/simplexml-strict-lists
Sep 9, 2023
Merged
* fixed: strict rules for elements in lists inside robovm.xml #730
Tom-Ski
merged 3 commits into
MobiVM:master
from
dkimitsa:workaround/simplexml-strict-lists
Sep 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstraints As discussed over gitter -- it becomes complicated to maintain build targeted for thumbv7 (32bit) version of ios when xcframework doesn't contain this slice. For example Firebase dropped 32 bit support and ios11+ only. This requires flexibility to be able to include frameworks only for specific architectures. Implementation is same as for `frameworkPaths` -- <frameworks>, <weakFrameworks>, <xcFrameworks> were extended with `arch` tag that limit the scope, for example: ``` <config> <frameworks> <framework arch="arm64">arm64_only_framework</framework> </frameworks> </config> ```
… fail on attempt to find provisioning profile
## Root case: SimpleXML issue: it allows unexpected tags to be present while parsing list, this caused side effect like empty text tags or null objects inserted into the list, for example ``` <frameworks> <wrong><framework>aaaa</framework><wrong/> </> ``` would result in (null, "aaaa") in list (beside the fact that structure is wrong) ## The fix General approach for a workaround is change List field type to custom POJO and make its serialization strict: E.g. instead of ``` @ElementList(required = false, entry = "framework") private ArrayList<String> frameworks; ``` list wrapper class to be used: ``` @element(required = false) private FrameworksList frameworks; ``` list wrapper class expected to be @root with strict = true, so unexpected tags will cause exception
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 15, 2024
…#730) * * <frameworks>, <weakFrameworks>, <xcFrameworks> -- qualified with constraints As discussed over gitter -- it becomes complicated to maintain build targeted for thumbv7 (32bit) version of ios when xcframework doesn't contain this slice. For example Firebase dropped 32 bit support and ios11+ only. This requires flexibility to be able to include frameworks only for specific architectures. Implementation is same as for `frameworkPaths` -- <frameworks>, <weakFrameworks>, <xcFrameworks> were extended with `arch` tag that limit the scope, for example: ``` <config> <frameworks> <framework arch="arm64">arm64_only_framework</framework> </frameworks> </config> ``` * * fixed test: should build config with skip signing otherwise it will fail on attempt to find provisioning profile * * fixed: strict rules for elements in lists inside `robovm.xml` ## Root case: SimpleXML issue: it allows unexpected tags to be present while parsing list, this caused side effect like empty text tags or null objects inserted into the list, for example ``` <frameworks> <wrong><framework>aaaa</framework><wrong/> </> ``` would result in (null, "aaaa") in list (beside the fact that structure is wrong) ## The fix General approach for a workaround is change List field type to custom POJO and make its serialization strict: E.g. instead of ``` @ElementList(required = false, entry = "framework") private ArrayList<String> frameworks; ``` list wrapper class to be used: ``` @element(required = false) private FrameworksList frameworks; ``` list wrapper class expected to be @root with strict = true, so unexpected tags will cause exception (cherry picked from commit fb27d44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
(also includes changes from #729)
NP
SimpleXML is quite old and outdated. And it would be nice to switch to another XML bindings such as Jackson/JAXP but all of them doesn't allow xml string mutation required for property values substitutions (e.g.
<executableName>${app.executable}</executableName>
)Root case:
SimpleXML issue: it allows unexpected tags to be present while parsing list, this caused side effect like empty text tags or null objects inserted into the list, for example
would result in (null, "aaaa") in list (beside the fact that structure is wrong)
The fix
General approach for a workaround is change List field type to custom POJO and make its serialization strict:
E.g. instead of
list wrapper class to be used:
list wrapper class expected to be @root with strict = true, so unexpected tags will cause exception