CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 12:48:59 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=366.323578,conversation_content-fragment;desc="conversation_content fragment";dur=411.122356,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=258.351501,nginx;desc="NGINX";dur=0.769848,glb;desc="GLB";dur=101.421868
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BkMTgY6uyym62KEzoDGhxbYqtpE8tD8UB6Hsx2F0djhBZYOLmui%2FH6zv6uoJhRtT3uBnSkX4SxZK1eB51kMKzE4yIrDIGc2f%2BizSv1y7wzawGwpKV73zDnSb59r2SiQY3ONO0z5XWHPk51IDv%2FnFN8PdGVFklFAw5AkRgask8gV8GPJMyMH1jAcWe6UCM2vAkr2VduyXQUqwN%2FJtvkcDszBS6ZS5jnvGBz92jyb33vxnyM98AeXNbsNJs59INE%2ByTOyDaydBW8q3YUtnbTpraA%3D%3D--txn5oooNIImYehaE--XqXZ1L9fWTciXBxcB6X9YA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1021385629.1753966139; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:48:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:48:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9408:2291D2:A75A23:C659C8:688B663B
* Java9 ByteBuffer API: desugaring plugin removed, added Api from Java9 by dkimitsa · Pull Request #728 · MobiVM/robovm · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 137
* Java9 ByteBuffer API: desugaring plugin removed, added Api from Java9 #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tom-Ski
merged 2 commits into
MobiVM:master
from
dkimitsa:rollback/bytebuffer-desugaring
Jul 7, 2023
Merged
* Java9 ByteBuffer API: desugaring plugin removed, added Api from Java9 #728
Tom-Ski
merged 2 commits into
MobiVM:master
from
dkimitsa:rollback/bytebuffer-desugaring
Jul 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reason for removal Recent reports in gitter about issues related to desugaring not working in case of subclasses of ByteBuffer. In particular `DirectByteBuffer`. Issue caused in not proper VTable for subclass in particular, methods injected into ByteBuffer during desugaring were not available in subclass. This caused wrong method to be invoked (like `DirectByteBuffer.load()` instead of `ByteBuffer.clear()`). The reason of this is the way how VTable is build: soot classes are used as source for methods. But these don't include injected/synthetic method (especially if class was build in previous session). Reworking `VTable` to use `classinfo` instead of soot class is possible but already looks as overcomplicated thing if comparing to override methods. The fix: RoboVM's runtime `ByteBuffer` class was extended with API from Java9, no need in desugaring in this case: ``` public ByteBuffer flip() public ByteBuffer clear() public ByteBuffer mark() public ByteBuffer reset() public ByteBuffer rewind() public ByteBuffer position(int newPosition) public ByteBuffer limit(int newLimit) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Reason for removal
Recent reports in gitter about issues related to desugaring not working in case of subclasses of ByteBuffer. In particular
DirectByteBuffer
. Issue caused in not proper VTable for subclass in particular, methods injected into ByteBuffer during desugaring were not available in subclass. This caused wrong method to be invoked (likeDirectByteBuffer.load()
instead ofByteBuffer.clear()
). The reason of this is the way how VTable is build: soot classes are used as source for methods. But these don't include injected/synthetic method (especially if class was build in previous session). ReworkingVTable
to useclassinfo
instead of soot class is possible but already looks as overcomplicated thing if comparing to override methods.The fix
RoboVM's runtime
ByteBuffer
class was extended with API from Java9, no need in desugaring in this case:Update 6th July
Added covariant Api to following classes