You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root case: SKStoreReviewPresentationWindow was kept in KEY_WINDOW. As result, it's dealloc wasn't called and sadly iOS15 has logic to triger code to pick another key window in SKStoreReviewPresentationWindow.dealloc.
This change might break some project that doesn't strong keep windows somewhere in AppDelegate
…eReviewController.requestReview();
Root case: SKStoreReviewPresentationWindow was kept in KEY_WINDOW. As result, it's dealloc wasn't called and sadly iOS15 has logic to triger code to pick another key window in SKStoreReviewPresentationWindow.dealloc.
This change might break some project that doesn't strong keep windows somewhere in AppDelegate
Root case: SKStoreReviewPresentationWindow was kept in KEY_WINDOW. As result, it's dealloc wasn't called and sadly iOS15 has logic to triger code to pick another key window in SKStoreReviewPresentationWindow.dealloc.
This change might break some project that doesn't strong keep windows somewhere in AppDelegate
Can't this be done without breaking backwards compatibility? (see comment). Perhaps with a configuration option or something?
I don't think it's good to potentially break any project just to fix those which use SKStoreReviewPresentationWindow.
@guillerodriguez I believe there is not much such project that doesn't keep window and relies on workaround I've removed.
anyway lib-gdx is not affected. in any case every release introduces some amount of breaking changes adopter have to adjust to.
@guillerodriguez I believe there is not much such project that doesn't keep window and relies on workaround I've removed.
anyway lib-gdx is not affected.
well, not every Robovm user is using libgdx..
in any case every release introduces some amount of breaking changes adopter have to adjust to.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root case: SKStoreReviewPresentationWindow was kept in KEY_WINDOW. As result, it's dealloc wasn't called and sadly iOS15 has logic to triger code to pick another key window in SKStoreReviewPresentationWindow.dealloc.
This change might break some project that doesn't strong keep windows somewhere in AppDelegate