CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 12:49:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=312.878458,conversation_content-fragment;desc="conversation_content fragment";dur=521.698357,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=274.379158,nginx;desc="NGINX";dur=0.788338,glb;desc="GLB";dur=101.651362
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=bJ9%2B7JhYWkeDzqzzIfQRj4LhkqokdTI1uq24ZwwL%2FcR%2FXDdRsCCd4s5lbt3VnYEjJnLMdwvyVcmiSiaw5GhmrNzgDDoT4CoKutSypuCeCefn02FkiZlNeZE5rbeVA1VQIHteQAYYdSDK5ZF7rMpNlby%2BuYdylVYMfDYYEtLr9Fe9ZEajacBLgRqE9AL4%2BQ6f0%2BJXogj2DP%2BpaKbZ4ltIgAbXT24yK%2FPj1mF3tb%2FT0QIBIiPCKTT0ISSEbywaViteKvqUSaUY0jsPXUw96G5H%2Bw%3D%3D--BKpgngbtUQ%2BAqpCH--%2B85KWWwfYbO4LK02OviDfg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2049060600.1753966176; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:49:36 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:49:36 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EC10:F2966:A2BD45:C02063:688B6660
* fixed: GlobalValueEnumeration crash #567 by dkimitsa · Pull Request #571 · MobiVM/robovm · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 137
* fixed: GlobalValueEnumeration crash #567 #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlobalValueEnumeration is fragile and will cause a crash if set of enum items in app differs from one available in system: ## case 1: global value is not available on target os (case as described in MobiVM#567) -- fails with `UnsatisfiedLinkError`. Happens when build for newer API version but run on old device. ### Root case: native to java marshaller code looks like bellow `valueOf`: ``` for (GlobalValueEnumeration v : values) { if (v.value().equals(value)) { return v; } ``` If entry is missing -- v.value() will cause `UnsatisfiedLinkError` ### the fix: code to be added to check if `v.isAvailable()` before doying `v.value().equals(value)` ## case 2: value is unknown for application. API mightreturns value that was introduced in new version. In this case same `valueOf` marshaller will not find the value in known `values` list and throw `IllegalArgumentException("No constant with value")`. ### the fix: dynamicaly create new entry of enumeration item and add it to `values`. its nit perfect to extend enum runtime but its the only stable not having application crashing.
dkimitsa
added a commit
to dkimitsa/robovm-bro-gen
that referenced
this pull request
Apr 7, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Background
issue #567.
not exact issue but same problem.
In general native-to-Java enum mapping is fragile in RoboVM as most likely app will crash if set of enum items in app differs from one available in system:
case 1: global value is not available on target os
(case as described in #567) -- fails with
UnsatisfiedLinkError
. Happens when app was built for newer API version but run on old device. As result global value is not available in the binary.Root case: native to java marshaller code looks like bellow
valueOf
:If entry is missing -- v.value() will cause
UnsatisfiedLinkError
the fix:
code to be added to check if
v.isAvailable()
before doingv.value().equals(value)
case 2: value is unknown for application.
Happens when marshalling value returned by system API and it is not known for application. Happens when old app runs on new OS. In this case same
valueOf
marshaller will not find the value in knownvalues
list and throwIllegalArgumentException("No constant with value")
.the fix:
It is against enum concept (e.g. it has to be fixed runtime but
GlobalValueEnumeration
is not a true enum) - the fix is to dynamically create new entry of enumeration item and add it tovalues
.discussion
This PR updates only
AVMetadataObjectType
but in general all bindings forGlobalValueEnumeration
to be updated