| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 12:49:29 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=425.909336,conversation_content-fragment;desc="conversation_content fragment";dur=733.308137,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=264.359099,nginx;desc="NGINX";dur=0.897724,glb;desc="GLB";dur=102.312672
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=l08f3zdtfmuKlqzAIxMH7jT%2BJe4bcgm6KY0y%2FQC3sqWfryvNkr%2BfI3AW5qxn3MjIIjQQkRNarT6zFWapfrY7%2FJwjOvvRunP1rD%2BhEkmulZsOtF%2BHNueuYOOkhAk3KsmJyvy9fQOkRMgpuGfOpeFxe3QwOqzlCAlrYbz4rIlX1qwcbIX6QDTYJI2f%2BqPwxNuLLtP1yo2h5EXpk0Rw2SIxjt9IWct2FJMOMAvx3Hr0BMojTUl%2Fhnuko7OYgq7GDQfsl31RBItAutubOxyJxNphZw%3D%3D--Lo6WG9khTzN1mFen--gqVE2XrpoW5u%2Bld%2FJUoXDQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.913898577.1753966168; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:49:28 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 12:49:28 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EB8E:5A781:4040FD:479980:688B6658
Fix for `Invalid Swift Support` issue by dkimitsa · Pull Request #346 · MobiVM/robovm · GitHub
Fix for
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 137
Fix for Invalid Swift Support issue
#346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading to AppleStore. root case assumed: during MobiVM#340 there was introduced defect that swift libs copy in 'SwiftSupport' also get stripped of ARM64E arch as result copy of these files were modified. As part of fix this commit does: * fixed issue with modifying of swift libs in 'SwiftSupport' * now all dynamic frameworks/libs/appext are being stripped to keep only archs same as in app (similar fix done in [rules_apple](bazelbuild/rules_apple@b238ee5)). This also reduce final IPA size * as all extra arches are being stripped introduced in MobiVM#340 `stripArchs` option is not required anymore and was removed * added functionality to strip bitcode from frameworks/libs/appext similar how XCode does, it also saves final IPA size
|
…ked from target.defaultArchs
… SwiftSupport then. Reverting to removing 'ARM64E' only which seems to be valid case
|
approach to strip every not used arch slice was bad, Apple rejects such SwiftSupport. Reverted back to removing simulator archs and ARM64E which seems to be working for me |
|
This fixes our issue with an advertising library that required the swift support libs, and the failed "does not match" swift validation email from apple testflight. |
|
@dkimitsa thanks once again! Is this mergeable? |
|
@florianf it seems to be working for me and Eric, but having more confirmation appreciated, changing thing is strip bitcode on dynamic frameworks, didnt test it on framework without bitcode, this is the only moment |
|
checked bitcode_strip on dynamic lib without bitcode -- doesn't fail. seems to be ok |
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Update: works for me, works for topic starter (Eric Nondahl).
This shell fix
Invalid Swift Supportissue when uploading to AppleStore.root case assumed: during #340 there was introduced defect that swift libs copy in 'SwiftSupport' also get stripped of ARM64E arch as result copy of these files were modified. As part of fix this commit does:
now all dynamic frameworks/libs/appext are being stripped to keep only archs same as in app (similar fix done in [rules_apple] (bazelbuild/rules_apple@b238ee5)). This also reduce final IPA sizeUPDATE: reverted to strip only ARM64Eas all extra arches are being stripped introduced in fix #338 -- removing arch64e #340UPDATE: this option was removed as well as it is enough only to strip ARM64EstripArchsoption is not required anymore and was removed`