CARVIEW |
Select Language
HTTP/2 301
date: Tue, 22 Jul 2025 08:40:11 GMT
content-length: 0
location: https://github.com/chakra-core/ChakraCore/pull/4907
server-timing: nginx;desc="NGINX";dur=0.464271,glb;desc="GLB";dur=100.253284
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=88aQmJeHuHzt0pdEvbFE3YwTwkl67eOpCZ6uCJh1C6Bs93FQfwNz0bjA%2FqlGmSw4RTV56WQBdCxZANOa%2FSxRBtIAl97Hg9V1As%2FmbVVNR%2BhZz74ZvWTqMmLjqlby28YZuCe9my1DRT9Vov%2BZ4zuSC5OautIL%2FNfhAkKpDBBU8oAXg9AGtJL9FTCPVoMapa%2FKsKWbRopzGFVfctUS7CuxwW2xDYHVVWcB9nSEUHilIyU6GKrR%2BYww1r8pbpu5HldTJshBWAAxyoh5Ed1xN0X8Ug%3D%3D--nows%2BogaTtkUzAiu--7jYsrNltpaAKnLjuK052SA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1189434086.1753173611; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 08:40:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 08:40:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A9E6:1E0F94:3A3C6A:41107A:687F4E6B
HTTP/2 200
date: Tue, 22 Jul 2025 08:40:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=438.090511,conversation_content-fragment;desc="conversation_content fragment";dur=616.256267,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=392.27556,nginx;desc="NGINX";dur=0.526726,glb;desc="GLB";dur=101.004666
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: A9E6:1E0F94:3A3CB0:4110D9:687F4E6B
Cache property enumeration in JSON.stringify like we do for Object.assign by sethbrenith · Pull Request #4907 · chakra-core/ChakraCore · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Cache property enumeration in JSON.stringify like we do for Object.assign #4907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chakrabot
merged 2 commits into
chakra-core:master
from
sethbrenith:user/sethb/stringify-cache-iter
Apr 2, 2018
Merged
Cache property enumeration in JSON.stringify like we do for Object.assign #4907
chakrabot
merged 2 commits into
chakra-core:master
from
sethbrenith:user/sethb/stringify-cache-iter
Apr 2, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
approved these changes
Mar 29, 2018
MikeHolman
approved these changes
Mar 29, 2018
@dotnet-bot |
@dotnet-bot test OSX static_osx_osx_debug please |
chakrabot
pushed a commit
that referenced
this pull request
Apr 2, 2018
…fy like we do for Object.assign Merge pull request #4907 from sethbrenith:user/sethb/stringify-cache-iter JSON payloads tend to be relatively repetitive, so we can save a lot on large serializations by reusing object property iteration. On a microbenchmark that serializes and parses a repetitive piece of data that I found in Speedometer, I see a 35% improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
JSON payloads tend to be relatively repetitive, so we can save a lot on large serializations by reusing object property iteration. On a microbenchmark that serializes and parses a repetitive piece of data that I found in Speedometer, I see a 35% improvement.