| CARVIEW |
Select Language
HTTP/2 301
date: Thu, 24 Jul 2025 05:11:29 GMT
content-length: 0
location: https://github.com/chakra-core/ChakraCore/pull/4797
server-timing: nginx;desc="NGINX";dur=0.584222,glb;desc="GLB";dur=101.218248
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=ZDCK2VCPMnZeKz2XS2vrK8f8udTFrP7AVLn7OB99%2ByQ1yn0LiIIwUTocOaqBLcX3lzuBuVy4wVAKld3XGvHLdEXr1bbXVrEb0c8XiS0YlBRu25ndbfUxmpYSKkCmtpppqNggQBvxPR49kOZibl4mv3g7OvALKeupPwW5%2FgOjs%2BIlvSpKtTEm4T39%2FVOOq1wrywGFX7sTx2cyxJ6DROSdMHafFLYwF1kHYz5ieOF37mmxk0LlgOOkyBoA72wP3KhpUubEg2N4BnFm%2FRY2piwOxw%3D%3D--PZhODBBPO5IZIcNf--6%2FNZ3zy7dEocxrzwudeRZw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.797355329.1753333889; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:11:29 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:11:29 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AC08:941DF:137225B:179EB0A:6881C081
HTTP/2 200
date: Thu, 24 Jul 2025 05:11:30 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=305.351615,conversation_content-fragment;desc="conversation_content fragment";dur=699.15999,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=261.338956,nginx;desc="NGINX";dur=0.994909,glb;desc="GLB";dur=101.883008
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: AC08:941DF:137229E:179EB4A:6881C081
Support disabling interpreter thunks in JSRT by digitalinfinity · Pull Request #4797 · chakra-core/ChakraCore · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support disabling interpreter thunks in JSRT #4797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chakrabot
merged 1 commit into
chakra-core:master
from
digitalinfinity:jsrt_thunk_master
Mar 10, 2018
Merged
Support disabling interpreter thunks in JSRT #4797
chakrabot
merged 1 commit into
chakra-core:master
from
digitalinfinity:jsrt_thunk_master
Mar 10, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHolman
approved these changes
Mar 9, 2018
agarwal-sandeep
approved these changes
Mar 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boingoing
approved these changes
Mar 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| @@ -341,6 +345,7 @@ namespace Js | |||
|
|
|||
| // Per script configurations | |||
| bool NoNative; | |||
| bool NoDynamicThunks; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike this capitalization but ok.
liminzhu
reviewed
Mar 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also add a note on JsRuntimeAttributeDisableNativeCodeGeneration that it does not stop all executable memory allocation and refer to this new flag. Other than that .
sethbrenith
approved these changes
Mar 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chakrabot
pushed a commit
that referenced
this pull request
Mar 10, 2018
…n JSRT Merge pull request #4797 from digitalinfinity:jsrt_thunk_master JsRuntimeAttributeDisableNativeCodeGeneration is not sufficient to disable all allocation of executable memory. Added a new attribute with explicitly this intent so that hosts running in locked down processes can embed ChakraCore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
JsRuntimeAttributeDisableNativeCodeGeneration is not sufficient to disable all allocation of executable memory. Added a new attribute with explicitly this intent so that hosts running in locked down processes can embed ChakraCore