| CARVIEW |
Select Language
HTTP/2 301
date: Thu, 24 Jul 2025 06:41:52 GMT
content-length: 0
location: https://github.com/chakra-core/ChakraCore/pull/4267
server-timing: nginx;desc="NGINX";dur=1.127792,glb;desc="GLB";dur=101.455761
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=aFucYmk6rmG9FUWR%2BzoZEou8aqFumDfh8Y9bp8lxzz0pqcYq9kdRljwi3fHz3RLdBEOURYvlDvC848amRh6uvycqgxJ9deHoFTvV0CTgvcntqNHJn73fW2yGw%2FXLjcMV30WJZqgW%2FEEIpq2UiXtXpqjGowPbtSL6keYKeJkUsS5Mibhze%2B26%2F3npyBVw8QH2jXt8ppW5rPkdcRmQSIqSGz3ZplbVAkcUA2hcpuFSuqqBKuQlPU1a0m7dHcVkpSOhGLxGINWjIGoaBD4gFtS9bw%3D%3D--bknC3HFpdgNDCSw2--FeKBDShfUpqMym%2F4DLo8TQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2012051259.1753339312; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 06:41:52 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 06:41:52 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CB1C:0A46:16075A:189C9C:6881D5B0
HTTP/2 200
date: Thu, 24 Jul 2025 06:41:53 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=282.148809,conversation_content-fragment;desc="conversation_content fragment";dur=829.440913,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=291.661782,nginx;desc="NGINX";dur=0.896374,glb;desc="GLB";dur=100.096322
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: CB1C:0A46:1607A4:189CF6:6881D5B0
jsrt: JsCreateExternalObjectWithPrototype by obastemur · Pull Request #4267 · chakra-core/ChakraCore · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
jsrt: JsCreateExternalObjectWithPrototype #4267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chakrabot
merged 1 commit into
chakra-core:master
from
obastemur:Jsrt_external_with_proto
Nov 20, 2017
Merged
jsrt: JsCreateExternalObjectWithPrototype #4267
chakrabot
merged 1 commit into
chakra-core:master
from
obastemur:Jsrt_external_with_proto
Nov 20, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also sent nodejs/node-chakracore#429 to node-chakracore using this new API. |
MSLaguana
reviewed
Nov 17, 2017
| @@ -122,4 +122,12 @@ | |||
| JsHasOwnProperty | |||
| JsCopyStringOneByte | |||
| JsGetDataViewInfo | |||
| JsCreateExternalObjectWithPrototype | |||
| JsObjectGetProperty | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these missing accidentally prior to now?
MSLaguana
approved these changes
Nov 17, 2017
jackhorton
reviewed
Nov 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: don't the native tests generally use the Catch unittest framework for us?
|
current design of the xplat native tests doesn't require |
chakrabot
pushed a commit
that referenced
this pull request
Nov 20, 2017
Merge pull request #4267 from obastemur:Jsrt_external_with_proto node-chakracore, each `ObjectTemplate` creation first creates an external object and sets prototype separately. `JsSetPrototype` is decently expensive to lazy call. This new `JsCreateExternalObjectWithPrototype` should supersede `JsCreateExternalObject` since prototype can be provided as `nullptr` if there is none. Also VS export Jsrt***ObjectProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
node-chakracore, each
ObjectTemplatecreation first creates an external object and sets prototype separately.JsSetPrototypeis decently expensive to lazy call.This new
JsCreateExternalObjectWithPrototypeshould supersedeJsCreateExternalObjectsince prototype can be provided asnullptrif there is none.Also VS export Jsrt***ObjectProperty