You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-chakracore, each ObjectTemplate creation first creates an external object and sets prototype separately. JsSetPrototype is decently expensive to lazy call.
This new JsCreateExternalObjectWithPrototype should supersede JsCreateExternalObject since prototype can be provided as nullptr if there is none.
Merge pull request #4267 from obastemur:Jsrt_external_with_proto
node-chakracore, each `ObjectTemplate` creation first creates an external object and sets prototype separately. `JsSetPrototype` is decently expensive to lazy call.
This new `JsCreateExternalObjectWithPrototype` should supersede `JsCreateExternalObject` since prototype can be provided as `nullptr` if there is none.
Also VS export Jsrt***ObjectProperty
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-chakracore, each
ObjectTemplate
creation first creates an external object and sets prototype separately.JsSetPrototype
is decently expensive to lazy call.This new
JsCreateExternalObjectWithPrototype
should supersedeJsCreateExternalObject
since prototype can be provided asnullptr
if there is none.Also VS export Jsrt***ObjectProperty