CARVIEW |
Select Language
HTTP/2 301
date: Tue, 22 Jul 2025 03:08:51 GMT
content-length: 0
location: https://github.com/chakra-core/ChakraCore/pull/3832
server-timing: nginx;desc="NGINX";dur=0.783035,glb;desc="GLB";dur=102.612972
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=Y44cJ9wlG%2FRuhazvna6I9S1AV%2BgcmdfJ0CUA1xL%2BkCk9RgJGLGWjPdH2ENYEWxlpNN%2BzTfm76qissx%2B177Zo4zOI%2BbE41s0BP%2FfwOk4mBhPtGQ2pnEOr5cIIFmNqDhdcLQLLF1%2FztLEDesMUgfmYiKYaqUBi3O82iVYG1u0P61PsKxMdO3SrQQ5EpNe5YBmPlndF%2FqOi3t%2F3WGLB0FvraK1BjlTMcVuUqc3jNiaqDE8kyaaQmIPM%2FAFlx0kwstBsDDb%2Bunx0xkaJaQF%2F3TU%2FAw%3D%3D--dcF6CAdbXdrhx4jH--pqCyyxZWOd4WW9KyesySkw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1762892550.1753153731; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 03:08:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 03:08:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DE6C:23C593:B718A:10A573:687F00C2
HTTP/2 200
date: Tue, 22 Jul 2025 03:08:52 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=235.13912,conversation_content-fragment;desc="conversation_content fragment";dur=987.640065,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=196.736751,nginx;desc="NGINX";dur=1.439687,glb;desc="GLB";dur=102.38078
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DE6C:23C593:B71A2:10A594:687F00C3
Enable inlining into functions which have try-catch/try-finally by meg-gupta · Pull Request #3832 · chakra-core/ChakraCore · GitHub
meg-gupta
force-pushed
the
tryinline
branch
from
September 28, 2017 19:41
meg-gupta
force-pushed
the
tryinline
branch
4 times, most recently
from
October 1, 2017 19:54
meg-gupta
force-pushed
the
tryinline
branch
5 times, most recently
from
October 5, 2017 22:10
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable inlining into functions which have try-catch/try-finally #3832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
932131e
to
ea8c518
Compare
@dotnet-bot test this please |
There are issues that need to be worked in the stack walker, I will reopen once they are fixed. |
ef3ef3a
to
d2e0a4e
Compare
@dotnet-bot dotnet-bot Linked test this please |
e5a6c57
to
d119260
Compare
rajatd
reviewed
Oct 6, 2017
rajatd
reviewed
Oct 6, 2017
lib/Runtime/Language/EHBailoutData.h
Outdated
|
||
public: | ||
EHBailoutData() : nestingDepth(-1), catchOffset(0), finallyOffset(0), parent(nullptr), child(nullptr), ht(HT_None) {} | ||
EHBailoutData() : nestingDepth(-1), catchOffset(0), finallyOffset(0), parent(nullptr), child(nullptr), ht(HT_None), inlineeCode(nullptr) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nullptr [](start = 137, length = 7)
init to false?
rajatd
reviewed
Oct 6, 2017
rajatd
reviewed
Oct 10, 2017
rajatd
reviewed
Oct 10, 2017
@rajatd Addressed review comments |
rajatd
approved these changes
Oct 11, 2017
- Avoid copy prop s0 (return symbol) into inlined functions - Clear inlinee callinfo : When there is an exception in an inlinee which is inside an EH region, we end up leaving datastructures in stackwalker dirty. If the EH handler was a try catch, and if the same code is executed in a loop in the interprerter after BailOnNoException, the stack walker due to dirty datastructures assumes that there are inlinee frames on the stack.
chakrabot
pushed a commit
that referenced
this pull request
Oct 12, 2017
…y-catch/try-finally Merge pull request #3832 from meg-gupta:tryinline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
No description provided.