| CARVIEW |
Select Language
HTTP/2 301
date: Mon, 21 Jul 2025 18:51:14 GMT
content-length: 0
location: https://github.com/chakra-core/ChakraCore/pull/3462
server-timing: nginx;desc="NGINX";dur=1.103051,glb;desc="GLB";dur=95.344005
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=Orb8Mb53G1Gbk3cF5QrNUGi0nAD%2B%2BrqziJXGxyyb1u7I7kIACyLZTQQd2emfefgp%2BfuVLU6pQibC8WNJN3ZCVwhQHd4rfBRsm5pFhx23ku5fWmpQEkpz8PctBEYRuFovGkCdaDjzVlXTB%2B2MKXmFcv5b7%2BxrtM5GHAF8kVwhXjMgy0Vky%2BxnA8opM58CsxqGexfFB6i50M%2B8hSGdN6b1MMKGhScP1zH%2FWCaroXzFl3Mm3CMsdURWDnOZ8Xa5J5FDkJFuk55iQBWs53HCPKQqAQ%3D%3D--UoZodA4tg%2B0Kgc%2B6--Ife3QdAIY5FadcmFQbTpfg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.200207142.1753123874; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 18:51:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 18:51:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 83E8:7BE7E:25CD53:2D0AC7:687E8C22
HTTP/2 200
date: Mon, 21 Jul 2025 18:51:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=383.080831,conversation_content-fragment;desc="conversation_content fragment";dur=860.042174,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=272.131862,nginx;desc="NGINX";dur=1.059222,glb;desc="GLB";dur=95.217206
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 83E8:7BE7E:25CD77:2D0AF1:687E8C22
Add JsGetDataViewInfo support by kfarnung · Pull Request #3462 · chakra-core/ChakraCore · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add JsGetDataViewInfo support #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
reviewed
Jul 31, 2017
lib/Runtime/Debug/TTEventLog.cpp
Outdated
| NSLogEvents::JsRTSingleVarArgumentAction* giAction = this->RecordGetInitializedEvent_DataOnly<NSLogEvents::JsRTSingleVarArgumentAction, NSLogEvents::EventKind::GetDataViewInfoActionTag>(); | ||
| NSLogEvents::SetVarItem_0(giAction, TTD_CONVERT_JSVAR_TO_TTDVAR(var)); | ||
|
|
||
| //entry/exit status should be set to clead by initialization so don't need to do anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in comment? I assume you mean clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was actually a copy/paste so I'll fix the other one as well.
Match the existing JsGetTypedArrayInfo signature in order to support making similar queries for DataViews.
MSLaguana
approved these changes
Jul 31, 2017
|
lgtm |
chakrabot
pushed a commit
that referenced
this pull request
Jul 31, 2017
chakrabot
pushed a commit
that referenced
this pull request
Jul 31, 2017
Merge pull request #3462 from kfarnung:dataview Match the existing JsGetTypedArrayInfo signature in order to support making similar queries for DataViews.
| /// The code <c>JsNoError</c> if the operation succeeded, a failure code otherwise. | ||
| /// </returns> | ||
| CHAKRA_API | ||
| JsGetDataViewInfo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is very similar API JsGetDataViewStorage. Can we reuse this? What is the use-case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought the same thing at first, but that method is purely interested in the raw storage. This method returns the parameters which were passed to the create method and I couldn't see a good way to get them (other than using script). Since TypedArray and DataView are both views over an ArrayBuffer, I think it makes sense for them to have similar interaction models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Match the existing JsGetTypedArrayInfo signature in order to support
making similar queries for DataViews.