Adding Jsrt function JsCopyStringOneByte #3408

MSLaguana · 2017-07-20T22:52:05Z

For scenarios where a string is known to have values fitting in
one byte, this method allows directly copying those values into a
char* buffer rather than having to copy to a uint16_t* buffer
and then to a char* buffer, and treating the string as raw bytes
rather than a valid utf8 encoding.

This will help reduce overhead in some common nodejs use cases.

digitalinfinity · 2017-07-20T23:08:48Z

lib/Jsrt/ChakraCore.h

@@ -679,5 +679,42 @@ CHAKRA_API
        _In_ JsPropertyIdRef propertyId,
        _Out_ bool *hasOwnProperty);

+/// <summary>
+///     Write JS string value into char string buffer without a null terminator


Can you add some more details about the semantics of this API, specifically what happens if the codepoint being copied is not within the char range

I had addressed that at https://github.com/Microsoft/ChakraCore/pull/3408/files#diff-ffd84896ce29f73bbba0ed9612cf37b2R699 unless you feel that is unclear?

Ah yes, that's great. Also clarify that UTF16 encoded codepoints are being truncated in this case. Actually, what happens in the case of a surrogate pair?

For scenarios where a string is known to have values fitting in one byte, this method allows directly copying those values into a char* buffer rather than having to copy to a uint16_t* buffer and then to a char* buffer, and treating the string as raw bytes rather than a valid utf8 encoding.

Merge pull request #3408 from MSLaguana:addJsrtOneByteStringCopy For scenarios where a string is known to have values fitting in one byte, this method allows directly copying those values into a char* buffer rather than having to copy to a uint16_t* buffer and then to a char* buffer, and treating the string as raw bytes rather than a valid utf8 encoding. This will help reduce overhead in some common nodejs use cases.

…ngOneByte Merge pull request #3408 from MSLaguana:addJsrtOneByteStringCopy For scenarios where a string is known to have values fitting in one byte, this method allows directly copying those values into a char* buffer rather than having to copy to a uint16_t* buffer and then to a char* buffer, and treating the string as raw bytes rather than a valid utf8 encoding. This will help reduce overhead in some common nodejs use cases.

MSLaguana requested a review from digitalinfinity July 20, 2017 22:52

msftclas added the cla-not-required label Jul 20, 2017

digitalinfinity requested a review from curtisman July 20, 2017 23:07

digitalinfinity approved these changes Jul 20, 2017

View reviewed changes

MSLaguana force-pushed the addJsrtOneByteStringCopy branch from 1a36fd6 to 9020556 Compare July 21, 2017 15:36

chakrabot merged commit 9020556 into chakra-core:release/1.7 Jul 21, 2017

MSLaguana deleted the addJsrtOneByteStringCopy branch October 2, 2017 16:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding Jsrt function JsCopyStringOneByte #3408

Adding Jsrt function JsCopyStringOneByte #3408

Uh oh!

MSLaguana commented Jul 20, 2017

Uh oh!

digitalinfinity Jul 20, 2017

Uh oh!

MSLaguana Jul 20, 2017

Uh oh!

digitalinfinity Jul 20, 2017

Uh oh!

Uh oh!

Adding Jsrt function JsCopyStringOneByte #3408

Adding Jsrt function JsCopyStringOneByte #3408

Uh oh!

Conversation

MSLaguana commented Jul 20, 2017

Uh oh!

digitalinfinity Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

MSLaguana Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

digitalinfinity Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

Uh oh!