| CARVIEW |
Select Language
HTTP/2 301
date: Tue, 22 Jul 2025 14:53:58 GMT
content-length: 0
location: https://github.com/chakra-core/ChakraCore/pull/3316
server-timing: nginx;desc="NGINX";dur=1.301019,glb;desc="GLB";dur=100.069099
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=5XP04zQho9bDeMeuPEdC5lsUAgKTnJb3cV84oShgaXmEyfB9NuM6ijOVXewckQi7SkNcU42M%2BIh9SpW7bIwZp%2BhwnYhDn%2BXT06Xho84n88eS7UQ9%2BtioPituXqDYlNwKwmvyGXGdyZJAB8O0jxyfENz6A1cxaqo4oXyaTk2POAudpd%2B2AaoYTVZmFApiTVQ8eJatbQp988obKOD48dof%2FF6kk3eJle%2FHVc2AXaPelx1%2FWH%2Fc1Uz%2BSSxZwNV5%2BnQ87vVGFMb2cNV%2FWO4ZhlS57Q%3D%3D--VsE9KRuCxudjrS2b--mMlPulME%2BLOE9Ph%2BTo%2FnVA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1793443050.1753196038; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 14:53:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 22 Jul 2026 14:53:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8396:36DE18:58D0C:67503:687FA606
HTTP/2 200
date: Tue, 22 Jul 2025 14:53:59 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=321.592662,conversation_content-fragment;desc="conversation_content fragment";dur=1212.127605,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=279.604951,nginx;desc="NGINX";dur=1.248364,glb;desc="GLB";dur=99.684455
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 8396:36DE18:58D3C:67546:687FA606
Expose JsHasOwnProperty by kfarnung · Pull Request #3316 · chakra-core/ChakraCore · GitHub
kfarnung
requested review from
mrkmarron,
digitalinfinity and
kunalspathak
and removed request for
digitalinfinity and
kunalspathak
July 11, 2017 01:37
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Expose JsHasOwnProperty #3316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Expose JsHasOwnProperty #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obastemur This may need to be updated based on the outcome of #3207. I just followed the existing pattern for |
kfarnung
requested review from
mrkmarron,
digitalinfinity and
kunalspathak
and removed request for
digitalinfinity and
kunalspathak
|
/cc @liminzhu |
lib/Jsrt/Jsrt.cpp
Outdated
| VALIDATE_INCOMING_OBJECT(object, scriptContext); | ||
| VALIDATE_INCOMING_PROPERTYID(propertyId); | ||
| PARAM_NOT_NULL(hasOwnProperty); | ||
| *hasOwnProperty = nullptr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*hasOwnProperty = nullptr; [](start = 7, length = 27)
shouldn't be initialized to false? I know at other places these variables are initialized to nullptr, but it should be false in those cases as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah, that came up in @obastemur PR as well, I'll take a quick scan and fix them up.
kunalspathak
approved these changes
Jul 11, 2017
kunalspathak
approved these changes
Jul 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this to the wiki as well.
|
LGTM |
kfarnung
commented
Jul 11, 2017
lib/Runtime/Debug/TTEvents.h
Outdated
| @@ -169,7 +169,8 @@ namespace TTD | |||
| CodeParseActionTag, | |||
| CallExistingFunctionActionTag, | |||
|
|
|||
| Count | |||
| Count, | |||
| HasOwnPropertyActionTag | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was dumb.
Enable support for usage in node's n-api. Added a new unit test for the functionality.
|
@mrkmarron Can you quickly sanity check my TTD changes? I'm going to need to write a new test to validate them. |
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Jul 11, 2017
chakrabot
pushed a commit
that referenced
this pull request
Jul 11, 2017
Merge pull request #3316 from kfarnung:hasownprop Enable support for usage in node's n-api. Added a new unit test for the functionality.
|
Added a page to the wiki and updated the reference list: https://github.com/Microsoft/ChakraCore/wiki/JsHasOwnProperty |
|
@kfarnung awesome! I added an experimental note to the wiki temporarily. Seems like a great addition to Chakra APIs as well and this is just in case Windows team has some feedback along the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Enable support for usage in node's n-api. Added a new unit test for
the functionality.