Prototype support for software write barrier in the JIT- every move
to an indir that's unknown target, with a pointer source, can trigger
the write barrier for that target

…r or not
trying pass by reference instead of pointer, we might be able to disable addressof(&) operator in write barrier wrapper

trying to avoid using WriteBarrierPtr<T> as function argument

Revert enabling GLOBAL_FORCE_USE_WRITE_BARRIER on Windows. That should be
a test feature and also not ready to turn on.
`template<ObjectInfoBits>` does not accept `library->Enum...` for
instantiation. Should use `JavascriptLibrary::Enum...`.
Fix a few assertions.
Fix one case of `insertBeforeInstr/assignInstr` name regression.

Also fix tab check.

Enable build.sh to run write-barrier check/analyze:
```
build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp
```

AsmJsModule.cpp calls TypedArray<..., true>::Create and results in link
error because the implementation is in cpp file and no explicit
instantiation. Also it would miss constructor implementation for the same
reason.
Fixed by moving both constructor and Create template implementations to
header file.

…ze from build.sh
Merge pull request chakra-core#1735 from jianchun:swbscript
Enable build.sh to run write-barrier check/analyze:
```
build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp
```
Also fix some build breaks and failures/assertions, fix copyright headers and tabs.

Fix NoWriteBarrierPtr::operator= signature.
Annotate `PointerNoBarrier(void) m_dynamicInterpreterThunk`. Fix
related usages.

…Thunk
Merge pull request chakra-core#1756 from jianchun:swbfix1
Fix NoWriteBarrierPtr::operator= signature.
Annotate `PointerNoBarrier(void) m_dynamicInterpreterThunk`. Fix
related usages.

For any write barrier allocations, the allocated type declaration should
be write-barrier decorated. Otherwise we'd see it in "pointerClasses" and
print an error on this type.
Move "RecyclerPointers.h" header file include location earlier to start
examing more GC types.

…ed type
Merge pull request chakra-core#1775 from jianchun:ubtype
For any write barrier allocations, the allocated type declaration should
be write-barrier decorated. Otherwise we'd see it in "pointerClasses" and
print an error on this type.
Move "RecyclerPointers.h" header file include location earlier to start
examing more GC types.

Expand `Pointer` macro to choose `WriteBarrierPtr/NoWriteBarrierPtr`
based on optional `Allocator` type using `WriteBarrierPtrTraits`.
(E.g. pointer fields but using with Arena, choose NoWriteBarrierPtr.)
Add `WriteBarrier` function to trigger write barrier on array content
when needed.
Added `CopyArray` function to copy array data. Triggers write barrier
on the array content when needed.
By default only pointer types, WriteBarrierPtr wrapper, or explicit
_write_barrier_policy trigger write barrier (when using Recycler).
Users can also use template instantiation to alter custom allocator/type
write barrier policy.
This change does not handle individual `Item` write barrier yet.

…ial)
Merge pull request chakra-core#1797 from jianchun:wballoc
Expand `Pointer` macro to choose `WriteBarrierPtr/NoWriteBarrierPtr`
based on optional `Allocator` type using `WriteBarrierPtrTraits`.
(E.g. pointer fields but using with Arena, choose NoWriteBarrierPtr.)
Add `WriteBarrier` function to trigger write barrier on array content
when needed.
Added `CopyArray` function to copy array data. Triggers write barrier
on the array content when needed.
By default only pointer types, WriteBarrierPtr wrapper, or explicit
_write_barrier_policy trigger write barrier (when using Recycler).
Users can also use template instantiation to alter custom allocator/type
write barrier policy.
This change does not handle individual `Item` write barrier yet.

BaseDictionary Key or Value can be of GC pointer type, potentially needs
write barrier on each entry item.
Use macro and template type traits to replace underlying entry Key/Value
type with WriteBarrierPtr when Key or Value is pointer type and used with
recycler allocators.
BaseDictionary methods still use original Key/Value types. Only the
underlying EntryType may contain swapped type. Most methods are not
affected. However, when WriteBarrierPtr is used, only immutable
TryGetReference should be used. (We cannot get a mutable reference and
possibly change the pointer underneath WriteBarrierPtr.)
Allow WriteBarrierPtr to take immutable address to support TryGetReference
(used a lot). Fixed a bunch of incorrect `const` usage.

Apply template traits to field types to simplify write barrier field
annotations. Now most annotations are Field or FieldNoBarrier (for pointers
known not needing write barrier).
Replaced `WB_ITEM_TYPE` with `Field`.

… items
Merge pull request chakra-core#1819 from jianchun:wbdict
BaseDictionary Key or Value can be of GC pointer type, potentially needs
write barrier on each entry item.
Use macro and template type traits to replace underlying entry Key/Value
type with WriteBarrierPtr when Key or Value is pointer type and used with
recycler allocators.
BaseDictionary methods still use original Key/Value types. Only the
underlying EntryType may contain swapped type. Most methods are not
affected. However, when WriteBarrierPtr is used, only immutable
TryGetReference should be used. (We cannot get a mutable reference and
possibly change the pointer underneath WriteBarrierPtr.)
Allow WriteBarrierPtr to take immutable address to support TryGetReference
(used a lot). Fixed a bunch of incorrect `const` usage.
Update: Apply template traits to field types to simplify write barrier field
annotations. Now most annotations are Field or FieldNoBarrier (for pointers
known not needing write barrier).

Merge pull request chakra-core#1833 from jianchun:swbfi

Make the clang plugin work on OSX.
OSX note: Must run the same clang binary for which the plugin was built for. e.g.:
```
./build.sh -n -d --icu=/usr/local/opt/icu4c/include/ \
                 --cxx=/usr/local/opt/llvm/bin/clang++ \
                 --cc=/usr/local/opt/llvm/bin/clang \
                 --wb-check lib/Runtime/Base/FunctionBody.cpp
```
Clean up plugin build script and sources.
Add plugin arguments support. Arguments can be directly passed from top
level "build.sh".
Changed --wb-check default output to "ERROR" only. To output verbose, use
plugin argument "-verbose":
```
build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp \
         --wb-args=-verbose
``````

…nd plugin arguments
Merge pull request chakra-core#1847 from jianchun:wbarg
Make the clang plugin work on OSX.
OSX note: Must run the same clang binary for which the plugin was built for. e.g.:
```
./build.sh -n -d --icu=/usr/local/opt/icu4c/include/ \
                 --cxx=/usr/local/opt/llvm/bin/clang++ \
                 --cc=/usr/local/opt/llvm/bin/clang \
                 --wb-check lib/Runtime/Base/FunctionBody.cpp
```
Clean up plugin build script and sources.
Add plugin arguments support. Arguments can be directly passed from top
level "build.sh".
Changed --wb-check default output to "ERROR" only. To output verbose, use
plugin argument "-verbose":
```
build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp \
         --wb-args=-verbose
```

there's functioninfo array using copy constructor to initialize

…ftware writebarrier

…k to master

Merge pull request chakra-core#2293 from leirocks:wb3
- false poisitive on EntryPointInfo->jsMethod after native address reuse in recycler
- false poisitive in arena allocator cacheBlockEnd reused in leaf block in recycler (sharing same page allocator)
- overload ChangeToAssign in JIT code, check all posible assign for write barrier
- missing barriers in various location

while etw rundown, this can happen in another thread which does not have card table initialized for its stack

Merge pull request chakra-core#2351 from leirocks:wbmerge

Annotate "Arguments" fields with FieldNoBarrier, so that the plugin checker
is happy.
Revert a JavascriptGenerator change Lei accidentally removed (credit to
Lei).
One StackTrace test config seems incorrect. It contained 2 "compile-flags"
and the 2nd overrided 1st, making the test exactly the same as a previous
one.

Merge pull request chakra-core#2355 from jianchun:swbtouchup
Annotate "Arguments" fields with FieldNoBarrier, so that the plugin checker
is happy.
Revert a JavascriptGenerator change Lei accidentally removed (credit to
Lei).
One StackTrace test config seems incorrect. It contained 2 "compile-flags"
and the 2nd overrided 1st, making the test exactly the same as a previous
one.

On Linux static builds ch uses overrided "operator delete" which
uses HeapAllocator. This runs into a possible destructor order
problem. Global moduleRecordMap (std::map) destructor may use
global HeapAllocator::Instance and must run after HeapAllocator
Instance destructor.
To workaround without touching global init/destructor order,
manually clear moduleRecordMap at end of RunScript().

Merge pull request chakra-core#2360 from jianchun:swbfi

OP_StModuleSlot was changing slot without write barrier. Annotate all
related code.
(Credit to Lei for finding it is module namespace related.)

This reverts commit c49e4af.
It should now work after Oguz removed wchar_t redef from PAL.

Found under stress unit testing. Debugger::m_context was not pinned
and could be GC collected when not in use.

the padding causes mismatch between the runtime and marshalling layer

…, Debugger)
Merge pull request chakra-core#2364 from jianchun:swbmodule
### swb: fix module namespace annotation
OP_StModuleSlot was changing slot without write barrier. Annotate all
related code.
(Credit to Lei for finding it is module namespace related.)
### Revert "fix a pal build issue on my machine"
This reverts commit c49e4af.
It should now work after Oguz removed wchar_t redef from PAL.
### pin Debugger::m_context
Found under stress unit testing. Debugger::m_context was not pinned
and could be GC collected when not in use.

Merge pull request chakra-core#2366 from leirocks:wboopjitfix
the padding causes mismatch between the runtime and marshalling layer

This reverts commit d665119.
Updated toolset should have this issue fixed.

…sis tool bug"
Merge pull request chakra-core#2369 from jianchun:revcodeanalysis
This reverts commit d665119.
Updated toolset should have this issue fixed.

only build the verification related code when GLOBAL_ENABLE_WRITE_BARRIER is on

…cation
Merge pull request chakra-core#2370 from leirocks:wbrecyclerfix
only build the verification related code when GLOBAL_ENABLE_WRITE_BARRIER is on

# Conflicts:
#	lib/Common/Memory/Recycler.h
#      lib/Common/Memory/Recycler.cpp
#	lib/Runtime/Library/JavascriptLibrary.h