@digitalinfinity @dilijev @ianwjhalliday @EdMaurer have a look.

Looks LoadScriptFile conflicts with changes in Linux branch

thanks @jianchun, I'll have a look at those. Also please have a look at the changes wrt to cross plat. I haven't done anything specific to enable that. That would be next stage.

@akroshg We will need to discuss whether it is appropriate to add the Microsoft copyright notice to bin/External/catch.hpp or to add an exclusion for that file or the entire directory.

If that code is licensed under a different license we might need to update LICENSE.txt and or thirdpartynotices.txt

/cc @EdMaurer @liminzhu on that decision.

For reference, full output of copyright check:

--------------
--- ERRORS ---
bin/External/catch.hpp ... does not contain a correct Microsoft copyright notice.
     /*
      *  Catch v1.5.6
      *  Generated: 2016-06-09 19:20:41.460328
      *  ----------------------------------------------------------
bin/nativetests/Scripts/splay.js ... does not contain a correct Microsoft copyright notice.
     ////////////////////////////////////////////////////////////////////////////////
     // base.js
     ////////////////////////////////////////////////////////////////////////////////
--------------

Sure @dilijev, I have initiated offline discussion for this.

Strange, *_release branch failures do not show up in the our buddy build system. @dilijev do you know if there are difference in between those?

@akroshg I think you mean the PreFAST warnings? The commands run in buddy builds are slightly different from the Jenkins scripts. We should probably add PreFAST analysis there. PreFAST analysis is only performed in release builds so that's why it only shows up in the release flavors.

You can see netci.groovy to see what commands are run in various builds so that you can reproduce the issues locally. Sent some more info about this offline.

To repro, you'll need to run:

call .\jenkins\buildone.cmd x64 release "/p:runcodeanalysis=true"  
powershell .\Build\scripts\check_prefast_error.ps1 . CodeAnalysis.err 

Can I run it by cd bin/nativetests/Scripts and ../../../Build/VCBuild/bin/x86_debug/nativetests.exe? Hope it can run without any deployment steps. Other ideas: Take a command line arg -d <scripts dir>? Or, translate all scripts to char[] and embed in nativetests.exe at build time?

This looks good to me at first glance. Some checkin gates have failed but overall I don't see anything I'd change about the approach taken.