skip iterating over method nodes, if search fields are empty

oraveczandrew · oraveczandrew · commit a355a6185aa2 · 2025-03-09T06:32:35.000+01:00
diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/searching/impl/MethodCallSearch.java b/src/main/java/the/bytecode/club/bytecodeviewer/searching/impl/MethodCallSearch.java
@@ -91,8 +91,6 @@ public JPanel getPanel()
     @Override
     public void search(ResourceContainer container, String resourceWorkingName, ClassNode node, boolean exact)
     {
-        final Iterator<MethodNode> methods = node.methods.iterator();
-
         String searchOwner = mOwner.getText();
         if (searchOwner.isEmpty())
             searchOwner = null;
@@ -105,6 +103,11 @@ public void search(ResourceContainer container, String resourceWorkingName, Clas
         if (searchDesc.isEmpty())
             searchDesc = null;
 
+        if (searchName == null && searchOwner == null && searchDesc == null)
+            return;
+
+        final Iterator<MethodNode> methods = node.methods.iterator();
+
         while (methods.hasNext())
         {
             final MethodNode method = methods.next();
@@ -116,9 +119,6 @@ public void search(ResourceContainer container, String resourceWorkingName, Clas
                 {
                     final MethodInsnNode min = (MethodInsnNode) insnNode;
 
-                    if (searchName == null && searchOwner == null && searchDesc == null)
-                        continue;
-
                     if (exact)
                     {
                         if (searchName != null && !searchName.equals(min.name))
