| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 453
deprecate: Add initial Deprecation Layer #10196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate: Add initial Deprecation Layer #10196
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 457427. |
|
CI Vulkan-ValidationLayers build # 20241 running. |
| const VkAllocationCallbacks* pAllocator, VkFramebuffer* pFramebuffer, | ||
| const ErrorObject& error_obj) const { | ||
| static bool reported = false; | ||
| if (reported) return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will only report once per function call
the return false is just because we never want a deprecation warning to "skip" the dispatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it can be not thread-safe (global reported ) if the function is called from multiple threads. But the worst thing that can happen the warning will be reported more than once? If that's the case, personally for me it does not look like a big issue, at least for the first version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did think about that, I would agree that it adding a 2nd warning would be a very painless threading issue to have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, a solution that involves atomics that are constantly checked looks quite heavy just to make things nicer.
| "default": true | ||
| }, | ||
| { | ||
| "key": "deprecation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what this looks like in VkConfig
|
CI Vulkan-ValidationLayers build # 20241 aborted. |
| "vkCreateFramebuffer is deprecated and this device supports VK_KHR_dynamic_rendering_local_read\nSee more " | ||
| "information about this deprecation in the specification: " | ||
| "https://docs.vulkan.org/spec/latest/appendices/deprecation.html#deprecation-dynamicrendering"); | ||
| } else if (api_version >= VK_API_VERSION_1_4) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spencer-lunarg Is API version derived from VkApplicationInfo::apiVersion or VkPhysicalDeviceProperties::apiVersion? What happens when you have a 1.4 loader, but a 1.3 ICD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the VkApplicationInfo::apiVersion (well its really a min of both)
What happens when you have a 1.4 loader, but a 1.3 ICD?
it will be 1.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Spencer. Min of both seems like the correct answer to me đź‘Ť
|
CI Vulkan-ValidationLayers build queued with queue ID 457830. |
|
CI Vulkan-ValidationLayers build # 20249 running. |
|
CI Vulkan-ValidationLayers build # 20249 aborted. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
e7f7ff6 to
9eb130f
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 461148. |
|
CI Vulkan-ValidationLayers build # 20281 running. |
|
CI Vulkan-ValidationLayers build # 20281 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
9eb130f to
0bbaef7
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 476220. |
|
CI Vulkan-ValidationLayers build # 20458 running. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
0bbaef7 to
a7d6ee2
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 476236. |
|
CI Vulkan-ValidationLayers build # 20459 running. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
a7d6ee2 to
1585ad5
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 476252. |
|
CI Vulkan-ValidationLayers build # 20460 running. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
1585ad5 to
81d0fd7
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 476326. |
|
CI Vulkan-ValidationLayers build # 20462 running. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
81d0fd7 to
a7a24fc
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 476364. |
|
CI Vulkan-ValidationLayers build # 20463 running. |
|
CI Vulkan-ValidationLayers build # 20468 running. |
|
CI Vulkan-ValidationLayers build # 20468 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
4bdaa67 to
3ed6b68
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 484130. |
|
CI Vulkan-ValidationLayers build # 20548 running. |
|
CI Vulkan-ValidationLayers build # 20548 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
3ed6b68 to
79f08b5
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 488580. |
|
CI Vulkan-ValidationLayers build # 20594 running. |
|
CI Vulkan-ValidationLayers build # 20594 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
79f08b5 to
1ea9c94
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 489671. |
|
CI Vulkan-ValidationLayers build # 20619 running. |
|
CI Vulkan-ValidationLayers build # 20619 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
1ea9c94 to
339be1c
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 489794. |
|
CI Vulkan-ValidationLayers build # 20622 running. |
|
CI Vulkan-ValidationLayers build # 20622 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
339be1c to
095475c
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 489850. |
|
CI Vulkan-ValidationLayers build # 20623 running. |
|
CI Vulkan-ValidationLayers build # 20623 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-deprecation
branch
from
095475c to
9598a08
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 489895. |
|
CI Vulkan-ValidationLayers build # 20624 running. |
|
CI Vulkan-ValidationLayers build # 20624 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One note.
Edit - This PR was updated a bit in #10590 and documentation can be now be found at https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/main/docs/deprecation_detection.md
Adds an initial working Deprecation Layer using the 1.4.314
vk.xmlchangesFew things about this
vk.xml