| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Support jp6.2 #14256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jp6.2 #14256
Conversation
| if [ "6.0" = ${patches_revison} ]; then | ||
| license_path="https://developer.download.nvidia.com/embedded/L4T/r36_Release_v3.0/release/Tegra_Software_License_Agreement-Tegra-Linux.txt" | ||
| fi | ||
| license_path="https://developer.download.nvidia.com/embedded/L4T/r${JETSON_L4T_RELEASE}_Release_v${JETSON_L4T_REVISION}/release/Tegra_Software_License_Agreement-Tegra-Linux.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for JetPack 6.1 and 6.2 by reworking the L4T patch script to handle multiple JetPack versions more generically.
- Replaced hardcoded version-specific logic with dynamic URL construction using environment variables
- Extended version matching to support JP 6.0 variants (36.3, 36.4, 36.4.3)
- Consolidated KBASE path assignment logic to eliminate redundant conditional blocks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| exit 1 | ||
| fi | ||
|
|
||
| # By default referencing license agreement of JP 5.0.2 |
Copilot
AI
Aug 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dynamic license URL construction assumes that JETSON_L4T_RELEASE and JETSON_L4T_REVISION variables are defined, but these variables are not set anywhere in the visible code. This will result in an invalid URL with empty variable substitutions.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a wrong comment, this should work right @Kontra2B ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the function is called the missing variables are defined
| KBASE=./Tegra/kernel/kernel-jammy-src | ||
| TEGRA_SOURCE_SYNC_SH="source_sync_6.0.sh" | ||
| TEGRA_TAG="jetson_36.3" | ||
| TEGRA_TAG="jetson_$JETSON_L4T_RELEASE.$JETSON_L4T_REVISION" |
Copilot
AI
Aug 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the license URL, this line uses undefined variables JETSON_L4T_RELEASE and JETSON_L4T_REVISION. The script will construct an invalid tag like 'jetson_.' instead of the expected format.
| TEGRA_TAG="jetson_$JETSON_L4T_RELEASE.$JETSON_L4T_REVISION" | |
| # Extract release and revision from JETSON_L4T_VERSION (e.g., r35.4.1) | |
| JETSON_L4T_RELEASE=$(echo "$JETSON_L4T_VERSION" | sed -E 's/^r([0-9]+)\..*$/\1/') | |
| JETSON_L4T_REVISION=$(echo "$JETSON_L4T_VERSION" | sed -E 's/^r[0-9]+\.([0-9]+).*$/\1/') | |
| TEGRA_TAG="jetson_${JETSON_L4T_RELEASE}.${JETSON_L4T_REVISION}" |
Copilot uses AI. Check for mistakes.
| KERNEL_RELEASE="5.10" | ||
| ;; | ||
| "36.3") | ||
| "36.3" | "36.4" | "36.4.3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to set 6.0 on 6.1 and 6.2 too?
Can we set 6.X maybe? and add a comment
36.3 --> 6.0
36.4 -> 6.1
36.4.3 --> 6.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same patch set originally for 6.0 applies for 6.1 6.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK that's great, can we explain it in the script like I suggested? or at least add a comment explaining why we continue with 6.0 even for 6.1 and 6.2 and the mapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to know when a patch was originally created and applied. Then when applied to 6.100 you know that is a legacy.
Adding your comment with revision --> JP version
|
Can you update this readme that we now also support 6.1 & 6.2? |
No particular reference to 6.0 to update. |
Labels
2 participants
support for JP6.1
support for JP6.2
l4t patch script reworked
Tracked on [RSDSO-20204]