| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 15 Oct 2025 05:01:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=341.557035,conversation_content-fragment;desc="conversation_content fragment";dur=3581.006564,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=338.616798,nginx;desc="NGINX";dur=0.661003,glb;desc="GLB";dur=138.813041
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=NUnxuQVDp%2BqtwX7W28bGu%2FF%2FpxjhYCn08A%2BSi8simMoJm8hJicICXnvyC9wgK1Jydf2s9nTUuX3PjRpbqKD8orspkX0LM4r9eJsy4P8BPrNHwEFPICEofZiRLoHE8aSseXp79RE81FCoDnEA6lSAIGzXSO2P6m8zdOFtRBkOf0c3ZCNSRDXxcCu1OmDe0J7%2Bpnir6%2FGwdc946ZCoMCj%2BGX9wKkcwRMbVxbZXywVdMUd6EfH4I45ciRlzEEG%2Ff%2FSo130nmWYxtK1wgp%2F47PcU%2FA%3D%3D--LIh6ileZzT1eFmyt--%2F03DPh464F9%2BSCZRR9alYQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1536431298.1760504499; Path=/; Domain=github.com; Expires=Thu, 15 Oct 2026 05:01:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 15 Oct 2026 05:01:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BB52:95D47:1306771:16EF0E3:68EF2AB3
Add Ethernet configuration API by OhadMeir · Pull Request #14228 · IntelRealSense/librealsense · GitHub
OhadMeir
force-pushed
the
traffic_shaping
branch
from
August 20, 2025 11:27
OhadMeir
force-pushed
the
traffic_shaping
branch
from
August 20, 2025 12:31
OhadMeir
force-pushed
the
traffic_shaping
branch
2 times, most recently
from
August 25, 2025 18:33
OhadMeir
force-pushed
the
traffic_shaping
branch
from
August 27, 2025 05:09
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add Ethernet configuration API #14228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive Ethernet configuration API support across C, C++, and Python interfaces for RealSense devices. The implementation provides both low-level C functions and high-level C++ wrapper classes to configure Ethernet settings like IP addresses, link priorities, DHCP settings, and network parameters.
Key changes include:
- Added new C API functions for Ethernet configuration in
rs.cppand headers - Created C++ wrapper class
eth_config_devicewith comprehensive configuration methods - Implemented Python bindings with IP address handling and enum support
- Updated existing viewer to use the new C++ API instead of direct hardware monitor commands
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rs.cpp | Implements core C API functions for Ethernet configuration using hardware monitor commands |
| include/librealsense2/hpp/rs_eth_config.hpp | Defines C++ wrapper class eth_config_device with type-safe configuration methods |
| include/librealsense2/h/rs_eth_config.h | Declares C API functions and enums for Ethernet configuration |
| wrappers/python/pyrs_eth_config.cpp | Python bindings for Ethernet configuration with IP address conversion utilities |
| unit-tests/live/config/test-eth-config.py | Updates test cases to use new Python API for validation |
| common/dds-model.cpp | Refactors viewer to use new C++ API instead of raw hardware monitor commands |
| examples/eth-config/rs-eth-config.cpp | Comprehensive example demonstrating all Ethernet configuration features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
OhadMeir
force-pushed
the
traffic_shaping
branch
from
40a8a5f to
43eecf0
Compare
OhadMeir
force-pushed
the
traffic_shaping
branch
from
43eecf0 to
f06ca05
Compare
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
remibettan
reviewed
Aug 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments
OhadMeir
force-pushed
the
traffic_shaping
branch
2 times, most recently
from
42266d5 to
be1a749
Compare
remibettan
reviewed
Aug 26, 2025
remibettan
reviewed
Aug 26, 2025
remibettan
reviewed
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very few comments
remibettan
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nir-Az
reviewed
Aug 26, 2025
examples/eth-config/CMakeLists.txt
Outdated
| # License: Apache 2.0. See LICENSE file in root directory. | ||
| # Copyright(c) 2025 RealSense, Inc. All Rights Reserved. | ||
|
|
||
| cmake_minimum_required(VERSION 3.8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to :
cmake_minimum_required(VERSION 3.10)
Like other cmake lists.
see: #14219
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a CI for that on GHA but since it's running your branch you don't see it..
Nir-Az
requested changes
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the min cmake version before merge otherwise all future PR's will fail
OhadMeir
force-pushed
the
traffic_shaping
branch
from
be1a749 to
ed9bc41
Compare
Nir-Az
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Tracked on [RSDEV-3754]
rs-eth-config