| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 16 Oct 2025 00:01:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=294.472759,conversation_content-fragment;desc="conversation_content fragment";dur=950.124832,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=375.809307,nginx;desc="NGINX";dur=1.057028,glb;desc="GLB";dur=139.048125
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XkPoNhIEWXUzlFPCm0QyAZAMHSOWr%2BPAxsSdCmbyK8O1dodG%2FsnM6F1QhyP8UfhQrYk3OVUZSQRWLUo752DerDutD8Mgg9xpwKdwpBkWUXmhCUbkmlt7dF5%2FDVYmF4vnarW530MiH73XXVmuW8bQ3rh4KFbpQnrVRPptMLNnoM%2B%2BwdY5AjSyvvT%2FFOFWApQVJExzXYAtE%2BhuPoyxRkGfm8etuol6yB5YmuOBB%2FBcGyzVTu7CMY5FUW0G7xsgc8kALiM1%2BfBzL%2FY1mwrJkNNCbw%3D%3D--Txybx38hKSKXet0R--05Wn6tbnxDffT%2FjsI8dgug%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1491323006.1760572864; Path=/; Domain=github.com; Expires=Fri, 16 Oct 2026 00:01:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 16 Oct 2026 00:01:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 87AE:188B8C:C4F37:12A949:68F035C0
Fixed Resource Leak In Point Cloud Example by martindevans · Pull Request #14185 · IntelRealSense/librealsense · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Fixed Resource Leak In Point Cloud Example #14185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Nir-Az
merged 2 commits into
IntelRealSense:development
from
martindevans:fix-docs-leak
Aug 13, 2025
Merged
Fixed Resource Leak In Point Cloud Example #14185
Nir-Az
merged 2 commits into
IntelRealSense:development
from
martindevans:fix-docs-leak
Aug 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a resource leak in the C# Point Cloud documentation example by properly disposing of intermediate frame objects created during point cloud processing.
- Separates the
pc.Process(depth)call from theAs<Points>()cast to ensure both objects are properly disposed - Adds proper
usingstatement for the intermediate frame object to prevent resource leaks
Comments suppressed due to low confidence (1)
wrappers/csharp/Documentation/cookbook.md:284
- [nitpick] The variable name 'frame' is too generic. Consider using a more descriptive name like 'processedFrame' or 'pointCloudFrame' to clarify that this is the result of point cloud processing.
using (var frame = pc.Process(depth))
Nir-Az
reviewed
Aug 13, 2025
| using (var frames = pipe.WaitForFrames()) | ||
| using (var depth = frames.DepthFrame) | ||
| using (var points = pc.Process(depth).As<Points>()) | ||
| using (var frame = pc.Process(depth)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR !
I suggest to rename frame to pc_frame
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
Renamed frame to pc_frame (review feedback)
Nir-Az
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Following this example for point clouds led to a resource leak.
As documented in the section on casting:
Fixed this.