| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 14 Oct 2025 17:09:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=417.014642,conversation_content-fragment;desc="conversation_content fragment";dur=2008.542712,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=471.763318,nginx;desc="NGINX";dur=2.029942,glb;desc="GLB";dur=138.943844
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=DACvsHLHwqkAejQtR5dVx9q6BBO0nWuvi%2F5PACmnQrBFPXm0ff%2BVO6bzXmb5LcGLWnubpnhxr%2B0PKGMzMlgbJPReJkqIccsVTKujTfGdtPV3wG9l24A0C03K1dxlSH0dMk6T7GKIKdjfY2bxTFW1ZfEyKp9aoeKLFdJx%2FsUCExAja3b3J3MNzmC2q%2FmypYWa6hSMWr%2FwgLg99XbSyb7a7sHNvYkSkqfXfuoLm%2Bf061PeKW22Cueiu8vKcEWj9LddWlzi8%2BoUm%2FexruM%2FOZpWbw%3D%3D--mWELTwXM12rloGJB--UngGFOjxq8QowQXqW%2BUTtQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1243389595.1760461740; Path=/; Domain=github.com; Expires=Wed, 14 Oct 2026 17:09:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Oct 2026 17:09:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B8BC:3AF5F8:E81D9F:10FB990:68EE83AC
fix hdr bug where no depth sensor exists by AviaAv · Pull Request #14179 · IntelRealSense/librealsense · GitHub
AviaAv
force-pushed
the
auto-hdr
branch
3 times, most recently
from
July 30, 2025 08:54
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix hdr bug where no depth sensor exists #14179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AviaAv
force-pushed
the
auto-hdr
branch
3 times, most recently
from
7a6b577 to
d9d1443
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an HDR bug that occurs when no depth sensor is available on the device. The main issue was that the HDR model constructor was attempting to access depth sensor options without proper error handling, causing crashes when a depth sensor doesn't exist.
Key changes:
- Added validation for HDR preset iterations to prevent invalid configurations
- Wrapped depth sensor initialization in try-catch to handle missing depth sensors gracefully
- Made option ranges non-const to allow initialization in the constructor body
- Fixed format string vulnerabilities in ImGui text rendering
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ds/advanced_mode/json_loader.hpp | Added validation for HDR preset iterations to ensure valid range |
| common/hdr-model.h | Changed option ranges from const to non-const to support deferred initialization |
| common/hdr-model.cpp | Added error handling for missing depth sensors and fixed format string issues |
|
|
||
| item_header.header_size = hdr_preset::item_header::size(); | ||
| item_header.iterations = static_cast<uint16_t>(std::stoi(item.at("iterations").get<std::string>())); | ||
| if( item_header.iterations <= 0 || item_header.iterations > 0xFFFF ) // not allowing 0 iterations |
Copilot
AI
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition item_header.iterations > 0xFFFF is redundant since item_header.iterations is of type uint16_t, which can only hold values from 0 to 0xFFFF. This check will never be true.
Suggested change
| if( item_header.iterations <= 0 || item_header.iterations > 0xFFFF ) // not allowing 0 iterations | |
| if( item_header.iterations == 0 ) // not allowing 0 iterations |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
|
|
||
| auto text_gain = _is_auto ? "Gain Delta" : "Gain Value:"; | ||
| ImGui::Text( text_gain ); | ||
| auto text_gain = _is_auto ? "Gain Delta:" : "Gain Value:"; |
Copilot
AI
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after 'Delta' - should be 'Gain Delta: ' to match the pattern used for 'Gain Value:'
Suggested change
| auto text_gain = _is_auto ? "Gain Delta:" : "Gain Value:"; | |
| auto text_gain = _is_auto ? "Gain Delta: " : "Gain Value:"; |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
common/hdr-model.cpp
Outdated
| else | ||
| control.depth_gain = (int)clamp((float)g, _gain_range.min, _gain_range.max); | ||
|
|
||
| auto text_exp = _is_auto ? "Exposure Delta" : "Exposure Value:"; |
Copilot
AI
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing colon after 'Delta' - should be 'Exposure Delta:' to match the pattern used for 'Exposure Value:'
Suggested change
| auto text_exp = _is_auto ? "Exposure Delta" : "Exposure Value:"; | |
| auto text_exp = _is_auto ? "Exposure Delta:" : "Exposure Value:"; |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
Nir-Az
reviewed
Jul 30, 2025
common/hdr-model.cpp
Outdated
| catch( const rs2::error & e ) | ||
| { | ||
| _hdr_supported = false; | ||
| LOG_ERROR( "Failed to initialize HDR model: " << e.what() ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG_DEBUG
Nir-Az
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Tracked on: [RSDSO-19396]