CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
remove age and gender from RealSense Viewer #14012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove age and gender from RealSense Viewer #14012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all age and gender detection components from the RealSense Viewer, including associated classes, methods, and UI labels.
- Deleted the age-gender detection header and implementation files
- Updated the face-detection pipeline and
detected_face
class to no longer track or display age/gender - Cleaned up related documentation and comments
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
wrappers/openvino/rs-vino/openvino-helpers.h | Adjusted face bbox helper comment |
wrappers/openvino/rs-vino/base-detection.h | Removed age_gender_detection reference from base class comment |
wrappers/openvino/rs-vino/age-gender-detection.h | Deleted age-gender detection header |
wrappers/openvino/rs-vino/age-gender-detection.cpp | Deleted age-gender detection implementation |
tools/realsense-viewer/openvino-face-detection.cpp | Removed age/gender logic and updated detected_face class |
Files not reviewed (1)
- tools/realsense-viewer/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (2)
tools/realsense-viewer/openvino-face-detection.cpp:30
- This stray brace appears to be left over from the removed
update_gender
method; it should be removed to avoid a dangling block.
{
tools/realsense-viewer/openvino-face-detection.cpp:31
- Remove this closing brace which currently forms an empty block unassociated with any method.
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes age and gender detection functionality from the RealSense Viewer, including related model loading, inference, and UI labels.
- Eliminated
age_gender_detection
class and its includes. - Stripped age/gender logic and parameters from
detected_face
andopenvino_face_detection
. - Cleaned up associated comments and UI string construction.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
wrappers/openvino/rs-vino/openvino-helpers.h | Removed gender-related example from bbox comment. |
wrappers/openvino/rs-vino/base-detection.h | Deleted age/gender mention in class comment. |
wrappers/openvino/rs-vino/age-gender-detection.h | Removed entire file for age/gender detection. |
wrappers/openvino/rs-vino/age-gender-detection.cpp | Removed entire implementation file. |
tools/realsense-viewer/openvino-face-detection.cpp | Stripped out age/gender logic, constructor params, model loads, and UI labels. |
Files not reviewed (1)
- tools/realsense-viewer/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
tools/realsense-viewer/openvino-face-detection.cpp:330
- [nitpick] Using
rsutils::string::from()
without any appended data may be unclear and incurs unnecessary formatting overhead; consider passing an explicit empty string literal""
or using an overload that omits the label argument.
objects.emplace_back(
face->get_id(),
rsutils::string::from(),
normalized_color_bbox,
normalized_depth_bbox,
face->get_depth()
);
Tracked on [LRS-1261]