| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 15 Oct 2025 23:42:10 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=318.807029,conversation_content-fragment;desc="conversation_content fragment";dur=1099.326588,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=354.622119,nginx;desc="NGINX";dur=1.504457,glb;desc="GLB";dur=138.62142
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=hIa%2BPqtTMbdcyuqinkxdoWCexxqQDjraKIsLglFfrYVNxROYvmIzHxmabtCHxMcy3bzNCvF2wG5TbbkoESbcjSaAWHX5hI22tMacGVqkkbtD2J4ox8NN95vb0ow%2F67mDfK%2Bk0pFhSNNxPgaF3uHjfe5t1clFZCU5c5feQNu4JCh2WfoTMUkn68fZPL2tEJxvNDM43GOFc7uqHtW%2B4bmNgdQhF4bilESer9WVlIDprRp2Z20Fa%2FXQJwXxegB3Z1TCOKexWC%2FuhHwsI4YocesFCA%3D%3D--1bZwuUeAiWRHHsSQ--bB9Co35xmuxmt0Ea6GzukQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.848986453.1760571729; Path=/; Domain=github.com; Expires=Thu, 15 Oct 2026 23:42:09 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 15 Oct 2026 23:42:09 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 960C:6B9C1:B3284:10E410:68F03151
Relax json setting enforcement by Nir-Az · Pull Request #13904 · IntelRealSense/librealsense · GitHub
Nir-Az
force-pushed
the
relax_json_context
branch
from
April 2, 2025 17:08
Nir-Az
force-pushed
the
relax_json_context
branch
from
April 3, 2025 09:57
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Relax json setting enforcement #13904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
force-pushed
the
relax_json_context
branch
from
2522cab to
62fbcd7
Compare
AviaAv
reviewed
Apr 3, 2025
| } | ||
| // Even that we sent allow_exceptions = false, we add an extra protection that if it will | ||
| // throws we catch it here and fallback to return missing_json. | ||
| catch( ... ) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we mean "set" instead of "sent" and "throw" instead of "throws"?
Also, let's please add LOG_WARNING or something similar in case it does throw, to indicate we fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling fixed.
json 3-rd party doesn't know the RS logger.
I return missing_json and the caller logs an error when he get's it
AviaAv
reviewed
Apr 3, 2025
|
|
||
| context::context( json const & settings ) | ||
| : _settings( load_settings( settings ) ) // global | application | local | ||
| , _device_mask( _settings.nested( "device-mask" ).default_value< unsigned >( RS2_PRODUCT_LINE_ANY ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much logic inside an initializer list.
It calls functions and 1 line depend on the function call before.
The init list execution order comes from the definition order and not from here so if someone will change it in the h in the future he will mess up the logic and won't even know.
I moved it after we log the version
Nir-Az
force-pushed
the
relax_json_context
branch
from
233b61d to
2ac4763
Compare
AviaAv
approved these changes
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Writing to the configuration is not an atomic operation and sometimes when the viewer is closed in the middle of the configuration writing the file is corrupted.
On this case until the user fix/delete the file the SDK context will throw an exception.
On this PR on such case, the context will start with default settings.
It will override the user's setting, yes.. but at least the SDK will be more robust to failures.
Upgrade minimal CMake version to 3.8 as GitHub Actions fail on lower cmake versions
Tracked on [LRS-1250]