| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 15 Oct 2025 12:33:31 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=400.797838,conversation_content-fragment;desc="conversation_content fragment";dur=1801.669508,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=347.318913,nginx;desc="NGINX";dur=1.430633,glb;desc="GLB";dur=137.339568
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=SfH1KiZ53tZ2xySSKgyERJKKsErAk3CjYCP5i3sngE1splpTqe3T3z6clCBNxkthJHymld0sMkU%2BQTbINB%2BhIyLhi145ooUuXlkynApmunt6zy%2BhplPkiV7xgpXQNrD4kytWl8DACRRq8gaE4Qu7b4A09%2BBQc2C7ybgWeNY2GACJvLZvh1NmWeaMXq7K006ggv%2BkDKvdr8n3AjNoXhhxi8eMCuOGLLGXrnMU6mAIIkcYfukY8mcjEOtQsqLOJ1Nq8Dv5OC9coJSTNYoBrYThhg%3D%3D--4Q9uwS0tnRo1lY90--IxkKbgSaTRZGJFd3HqV2zQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1437073649.1760531609; Path=/; Domain=github.com; Expires=Thu, 15 Oct 2026 12:33:29 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 15 Oct 2026 12:33:29 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C63A:B10CF:165006:18D8E5:68EF9499
Feature/ashraf/lib cicd by ashrafk93 · Pull Request #13894 · IntelRealSense/librealsense · GitHub
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
4 times, most recently
from
March 30, 2025 13:09
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
from
March 30, 2025 13:11
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
2 times, most recently
from
March 30, 2025 17:25
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
from
March 30, 2025 17:31
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Feature/ashraf/lib cicd #13894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Nir-Az
merged 19 commits into
IntelRealSense:development
from
ashrafk93:feature/ashraf/libCICD
Apr 3, 2025
Merged
Feature/ashraf/lib cicd #13894
Nir-Az
merged 19 commits into
IntelRealSense:development
from
ashrafk93:feature/ashraf/libCICD
Apr 3, 2025
+83
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Mar 30, 2025
unit-tests/run-unit-tests.py
Outdated
| print( ' --device <> Run only on the specified devices; ignore any test that does not match (implies --live)' ) | ||
| print( ' --no-reset Do not try to reset any devices, with or without a hub' ) | ||
| print( ' --hub-reset If a hub is available, reset the hub itself' ) | ||
| print( ' --custom-fw If custom fw provided flash it if its different that the current fw installed' ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe --custom-fw-d400?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
Nir-Az
reviewed
Mar 30, 2025
| image_file = find_image_or_exit(product_name) if not custom_fw_path else custom_fw_path | ||
| cmd = [fw_updater_exe, '-r', '-f', image_file] | ||
| if custom_fw_path: | ||
| # unsiged fw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsigned
Nir-Az
reviewed
Mar 30, 2025
unit-tests/test-fw-update.py
Outdated
| if recovered or 'nightly' not in test.context: | ||
| if recovered or 'nightly' not in test.context or custom_fw_path: | ||
| # In nightly, we always update; otherwise we try to save time, so do not do anything! | ||
| # If custom fw was provided always update for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the libci param description you wrote
'If custom fw provided flash it if its different that the current fw installed'
Why not implementing it?
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
4 times, most recently
from
acb1aaa to
7a630e2
Compare
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
from
7a630e2 to
e28eebb
Compare
Nir-Az
reviewed
Mar 30, 2025
| no_reset = False | ||
| hub_reset = False | ||
| skip_disconnected = False | ||
| custom_fw_path='' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d400
Nir-Az
reviewed
Mar 30, 2025
unit-tests/test-fw-update.py
Outdated
| filename = os.path.basename(file_path) | ||
| match = re.search(r'Image(\d+)_(\d+)_(\d+)_(\d+)', filename) | ||
| if match: | ||
| return rsutils.version(".".join(match.groups()[:3])) # Skip the last digit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the last digit is not always 0, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens when the last digit is not 0?
will the fw version include the last digit ? cause i saw that currently it doesn't and it shows only 5.7.6 not 5.7.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to skip last digits only if its zero
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
2 times, most recently
from
6c160ad to
8255e40
Compare
ashrafk93
force-pushed
the
feature/ashraf/libCICD
branch
from
8255e40 to
55f0e76
Compare
Nir-Az
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
custom fw install