| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add cmdline args to realsense-viewer #12175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit e78e321c9be09c72ce3374530fd518eae148dcd5)
(cherry picked from commit 00df7879e9d9a92888e7017fd2a4478cff91a917)
| press_button_model grid_object_button{ u8"\uf1cb", u8"\uf1cb", "Configure Grid", "Configure Grid", false }; | ||
|
|
||
| viewer_model(context &ctx_); | ||
| viewer_model(context &ctx_, bool disable_log_to_console = false ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now this is OK, but if there will be more options controlled then we need to pass in a more flexible way, like JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| { | ||
| TCLAP::CmdLine cmd( "realsense-viewer", ' ', RS2_API_FULL_VERSION_STR ); | ||
| #ifdef BUILD_EASYLOGGINGPP | ||
| TCLAP::SwitchArg debug_arg( "", "debug", "Turn on LibRS debug logs" ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to docs please.
Both tools needs CLI parameters documented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to docs please.
Both tools needs CLI parameters documented
Need is quite a strong word. They document it by supporting |
Need means that we post a table of parameters and if someone add a new flag or change the table needs to be changed. If you think the table is not needed we can speak about it. |
I think it's not needed. |
I think it gives the user the ability to see the tool capabilities before trying to build and run. |
| } | ||
|
|
||
| if( mask & RS2_PRODUCT_LINE_NON_INTEL ) | ||
| if( mask & RS2_PRODUCT_LINE_NON_INTEL && ! ( mask & RS2_PRODUCT_LINE_SW_ONLY ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this kind of changes needs to be added on other products as well and will not shown as conflicts.
We need to be carefull with those refactors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is compatible with all products. The flag is the --sw-only flag is is mostly on for our development and in unit-tests. We are careful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add the flag when I do the PR with the 555e
Nir-Az
changed the title
Nir-Az
changed the title
Labels
3 participants
--debugto force debug output to console--sw-onlyto enable easier DDS-only debugging (same flag as inrs-enumerate-devices)