You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole point of this is to separate out the platform-specific (backend_device_group) from the base device_interface defined in the core. device_info played a minor role before, but is now much more central to a device.
To that end, I also split backend.h into multiple smaller files in a platform/ folder.
The reason will be displayed to describe this comment to others. Learn more.
We build it in GHA, which is where I saw things fail until I fixed these include.
I don't remember why jni.h is needed or why I removed, but it compiled without it so there doesn't seem to be a dependency in this .cpp...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole point of this is to separate out the platform-specific (
backend_device_group
) from the basedevice_interface
defined in the core.device_info
played a minor role before, but is now much more central to adevice
.To that end, I also split
backend.h
into multiple smaller files in aplatform/
folder.Lots of files, but most changes are in includes.
Tracked on [LRS-885]