You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows already does this -- so this does the same in Linux:
Puts everything together, so it's easy to find and create artifacts
Turns out, cmake --build . --config <> doesn't work in Linux!
See here: "For single configuration generators like Makefile Generators ... the configuration is specified at configure time by the CMAKE_BUILD_TYPE variable"
So I changed all the GHA runners to use it in Linux/Mac/Android
This can default to be empty, so the default is Release
Had to change LibCI to expect collaterals in same place as Windows
Plus fixed some warnings on Linux...
Note that this has to be accompanied by additional PRs in other repos for our CI.
I'm rerunning libCI (manually) - found an issue with another script.
Note that once all the PRs go in, we have to update all branches with development right away or they likely won't pass libCI or Jenkins builds.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows already does this -- so this does the same in Linux:
cmake --build . --config <>
doesn't work in Linux!CMAKE_BUILD_TYPE
variable"Release
Plus fixed some warnings on Linux...
Note that this has to be accompanied by additional PRs in other repos for our CI.
Tracked on [LRS-817]