You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still don't completely understand the bridge, and lots of the names are not clear enough.
There are public methods like add_implicit_profiles and commit that even with the comments I don't feel like I understand when to call them and if it is needed to call them at all.
Aren't stream_bridge::is_explicit and stream_bridge::is_implicit opposites?
I kind of feel like the bridge should be dds_sensor_based_device_sensor inheriting from dds_device_sensor, and maybe even in the application level not realdds.
The reason will be displayed to describe this comment to others. Learn more.
How about a DFU device? I can see situations where a device is strictly for the control/notification mechanism. I agree it's then not strictly a "device" but we'll only know later if this makes sense or not.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal was:
rs-dds-server
automatically start streaming when a stream is opened, while allowing maximum flexibility when then trying to stream other streamsCurrently:
Tracked on [LRS-385]