| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:32:26 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=362.251116,conversation_content-fragment;desc="conversation_content fragment";dur=929.230417,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=336.925776,nginx;desc="NGINX";dur=1.232585,glb;desc="GLB";dur=101.121579
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=IP0KxPXetS5zXj0usuVcwEuiar5VAfroVvGBMlvvij1j75c4GpyynKPO3i0HRqpOKhf1ZXlW6n%2Bf3q2fmt9cXP3kAOoWUNLUHe28iqBMKmVnkdEY3OUoJ2rD1tGPTzllrR486UuYhFkNdkheF3NEhZm0qrJ7eoNZQDedCQB1HFF4Zp4WdNtgjU3r7oXF96ItmIfz6uG07A%2Bzg8jPh6KP0tK0w4eCg8ESnk5ACIy%2BVXrn9sX0LTcYP5rf%2FKlFA%2ByeXpaa1zZXsqkONZmLy89OWQ%3D%3D--cLHdLuB0Ua71p33r--hYY9bZVOyHImmsFU6Jr%2B%2FQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1916139387.1753561945; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:32:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:32:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 99F4:242CC6:8CE69E:B65B05:68853B59
[DYN-4517] TuneUp will fail to register if not closed between graph runs by ivaylo-matov · Pull Request #43 · DynamoDS/TuneUp · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 15
[DYN-4517] TuneUp will fail to register if not closed between graph runs #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reddyashish
merged 10 commits into
DynamoDS:master
from
ivaylo-matov:DYN-4517-TuneUp-will-fail-to-register-if-not-closed-between-graph-runs
Jul 2, 2024
Merged
[DYN-4517] TuneUp will fail to register if not closed between graph runs #43
reddyashish
merged 10 commits into
DynamoDS:master
from
ivaylo-matov:DYN-4517-TuneUp-will-fail-to-register-if-not-closed-between-graph-runs
Jul 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builds without errors
now loads in all versions from the Extensions menu
- TuneUp active only when MenuItem.IsChecked - switches to manual model when activated - ViewModel.IsTuneUpChecked tracks MenuItem.IsChecked
QilongTang
reviewed
Jun 28, 2024
QilongTang
reviewed
Jun 28, 2024
QilongTang
reviewed
Jun 28, 2024
TuneUp/TuneUpViewExtension.cs
Outdated
| // When _Extensions is specified, TuneUpMenuItem goes to the View menu in Dynamo 3.0- | ||
| // and does not appear in Dynamo 3.1+. | ||
| // We need to specify _View for TuneUpMenuItem to be added to the Extensions menu | ||
| var extensionsMenuItem = dynamoMenuItems.Where(item => item.Header.ToString() == "_View"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused by this a bit.. we specify _View to be added to Extentions munue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You and me, brother 😁
I could not figure out why that is, might have to do with the way Dynamo loads the menus. Looking and the old master seem like this hasn't worked before either. In old demos Show TuneUp is always called from the View menu although the code was specifying _Extensions. I thought this is decent workaround for the time being as it's not a part of the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- Thank you Ivo for shifting it to Extensions. This is 100% where it should live!
- We should make sure the coat is hardened, so if there is a proper way to do it please refactor :)
aligned to .csproj & .props in master
|
@ivaylo-matov there are still 2 conflicts. |
…ot-closed-between-graph-runs
|
@reddyashish , sorry. Tried to resolve them before a couple of times, but wasn't sure if I should Commit Merge. |
reddyashish
approved these changes
Jul 2, 2024
|
LGTM. Thank you @ivaylo-matov. |
|
@QilongTang Will open a new PR to publish the tuneup package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR aims to address https://jira.autodesk.com/browse/DYN-4517.
It also addresses 1. of https://autodesk.slack.com/archives/CPJ5UQW0Z/p1719284511762389 : TuneUp to not impact performance when not being actively used.
FYI
@QilongTang
@Ashish Ganta
@Amoursol