You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.
Purpose
This PR is about adding the host multi-selection and part of the regular package publishing workflow.
What I have tested:
Host dependency will be optional filed for now, so dialog canSubmit check will not mandate it
Publishing to local works fine with the right info serialized
Publishing from existing package works fine with the right info pre filled in the combox
TODO:
Refine the UI to see if we should simply add it below versions otherwise need to rewrite the combobox here since it does not fit.. - [ ] Add publish check for host dependencies
Add multi selection part
What it looks now
The pkg.json generated when publishing the package locally
Errors and Failures:
1) Test Failure : DynamoCoreWpfTests.PublishPackageViewModelTests.NewPackageVersionUpload_DoesNotThrowExceptionWhenDLLIsLoadedSeveralTimes
Expected: No Exception to be thrown
But was: (Object reference not set to an instance of an object.)
at Dynamo.PackageManager.PublishPackageViewModel.set_SelectedHosts(List`1 value) in E:\Builds\SSCI_Dynamo\DynamoDS_Dynamo\PublishPackageWithHost\src\DynamoCoreWpf\ViewModels\PackageManager\PublishPackageViewModel.cs:line 458
at Dynamo.PackageManager.PublishPackageViewModel.FromLocalPackage(DynamoViewModel dynamoViewModel, Package l) in E:\Builds\SSCI_Dynamo\DynamoDS_Dynamo\PublishPackageWithHost\src\DynamoCoreWpf\ViewModels\PackageManager\PublishPackageViewModel.cs:line 728
Figured this out, this does not fail in VS 2019 but a null check for setter is apparently needed for lower version of C#
* Initial Commit
* Add hosts selections
* Add the multi selection
* Multiple Host Selection Display
* Correct Host Dependencies in Json for publishing and download
* Code Clean up
* More Cleanup and Comments
* Bug fixing - publish version
* More comments and regression
* Initial Commit
* Add hosts selections
* Add the multi selection
* Multiple Host Selection Display
* Correct Host Dependencies in Json for publishing and download
* Code Clean up
* More Cleanup and Comments
* Bug fixing - publish version
* More comments and regression
* Initial Commit
* Add hosts selections
* Add the multi selection
* Multiple Host Selection Display
* Correct Host Dependencies in Json for publishing and download
* Code Clean up
* More Cleanup and Comments
* Bug fixing - publish version
* More comments and regression
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
This PR is about adding the host multi-selection and part of the regular package publishing workflow.
What I have tested:
canSubmit
check will not mandate itTODO:
- [ ] Add publish check for host dependenciesWhat it looks now

The
pkg.json
generated when publishing the package locallyDeclarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
@Amoursol