You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a copy of the one that Craig made: #9620
Instead of removing the TraceUtils class from from Protocore.Lang namespace, we just obsolete it for now.
Since this trace data is checked for in the Execute function, this part of the code is executed for all the graphs. A small percentage decrease or increase in the run times for those graphs, that take less absolute run times can be ignored.
Performance results comparison with the base line data(for model tests):
…mprovements Part II (#9665)
* Move Engine TraceUtils methods to DynamoServices with ThreadStatic backing
* Convert GetTrace and SetTrace to user ThreadStatic mechanism
* Remove Engine TraceUtils
* Clean up tests to remove thread local storage reference
* Clean up callsite Trace workflow
* Remove expression body syntax
* Remove inline out declaration
* Obseleting the class instead of removing it
* Sort usings.
* Removing the TODO comment that is not valid anymore
Very impressive performance uplift! @aparajit-pratap I'm no longer up to date with the VM but is this improvement attributed to fixing a fundamental issue in the callsites or an iterative process?
@aparajit-pratap, @saintentropy Interesting! and thanks for the background. Btw did this arise due to performance profiling? Curious how much effort is still put in making the VM faster at this stage :)
@saintentropy has been slowly chipping away at the VM trying to make performance improvements and he has made some along the way. We have more ongoing work in this area. One of the things I was looking at is at optimizing execution for modified inputs in graphs: #9485. This was based on one of your design proposals some time ago.
This work is yet to be fully completed and merged.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a copy of the one that Craig made: #9620
Instead of removing the TraceUtils class from from Protocore.Lang namespace, we just obsolete it for now.
Since this trace data is checked for in the Execute function, this part of the code is executed for all the graphs. A small percentage decrease or increase in the run times for those graphs, that take less absolute run times can be ignored.
Performance results comparison with the base line data(for model tests):


Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner @aparajit-pratap @QilongTang @saintentropy