CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 12:16:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=304.110649,conversation_content-fragment;desc="conversation_content fragment";dur=863.508219,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=247.794968,nginx;desc="NGINX";dur=1.460626,glb;desc="GLB";dur=101.150614
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=DDQ1tLVMOGUXu93XopqTS2AYtDENaaFDxsmI9XpU7OSuob43d6nN6rA1I%2FxQIJqBwcgn1ElZsayaK0iYSkf2qjCpvhutdIZWGLfAGSE%2FyTlb1z%2BSI4cAJShpf5TbcInKHIfBhkiwAjq67IIaOKzPtNp8kNnC0Rw0BJeT%2BzqiPLt%2BptaNOntbDDIdqeYrGKtiMWIFab%2FBQorwOtMT65wwq9auelfkNh7YhooE2UPHhVJHT9IeTi4mXY4w%2Bd5nQY%2FqCM4XoKkS8BhDgiE%2B5D8ySw%3D%3D--MjMrBeoj1uRIVh4L--Cn5%2Bha5qfEuP27xEgyN0HQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.122946302.1753618603; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:16:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:16:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8E02:37D5F1:DF5873:126CDE9:688618AB
fix to List.CartesianProduct node by aparajit-pratap · Pull Request #9431 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
fix to List.CartesianProduct node #9431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aparajit-pratap
merged 6 commits into
DynamoDS:RC2.1.0_master
from
aparajit-pratap:fixApplyNested_2.1
Jan 16, 2019
Merged
fix to List.CartesianProduct node #9431
aparajit-pratap
merged 6 commits into
DynamoDS:RC2.1.0_master
from
aparajit-pratap:fixApplyNested_2.1
Jan 16, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mjkkirschner I'm not happy with this solution of adding more |
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Jan 16, 2019
* fix to List.CartesianProduct node * add DYN file for test * revised fix * reuse code * add string overload for ValueAtIndex method for for loops * add for loop test with single value to array promotion
7 tasks
aparajit-pratap
added a commit
that referenced
this pull request
Jan 16, 2019
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
May 31, 2019
7 tasks
reddyashish
added a commit
that referenced
this pull request
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Fixes regression caused by #9388 in
List.CartesianProduct
and adds missing test.As a result of #9388
for
loop behavior had changed. As a result of makingGet.ValueAtIndex
disallow array promotion of its list argument, for loops inside imperative language blocks no longer iterated over a single value. Previously the single value was getting promoted to an array before thefor
loop could iterate over it. This is because the for loop expression is first compiled to AST's as shown in this example:The fix is to add yet another ValueAtIndex like ZT method specifically for
for
loop compilation that does not have theAllowArrayPromotion(false)
attribute.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner
@QilongTang
FYIs
@smangarole