You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.
Hi @QilongTang , it seems like all the subclass of DSDropDownBase would set their SelectedString and save to .dyn files, right? It looks good to me. I would close my PR.
@QilongTang in your manual testing did you also switch the version of revit or only the version of dynamo on which you opened and saved the graphs? To replicate this the number of items or order of them must be changed between saving and loading, which would be accomplished by adding new types (family types) or switching revit version. Seems a unit test could also replicate this issue with some mocked data.
@mjkkirschner See picture I attached, I tested a valid use by opening a DYN saved w/ Dynamo 1.3.3 Revit 2019 in Dynamo 2.2.0 R2020. The selection is differen index between two version. I will make unit tests.
* SaveDropDownSelectedItem
* Updates to use internal cate
* Update comments
* Update the syncing logic
* Add Dynamo 2.1 Dropdown Unit Tests
* Add XML tests
* Update Unit tests
* SaveDropDownSelectedItem
* Updates to use internal cate
* Update comments
* Update the syncing logic
* Add Dynamo 2.1 Dropdown Unit Tests
* Add XML tests
* Update Unit tests
* SaveDropDownSelectedItem
* Updates to use internal cate
* Update comments
* Update the syncing logic
* Add Dynamo 2.1 Dropdown Unit Tests
* Add XML tests
* Update Unit tests
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
REVIT-141868
DynamoRevit 2.x Categories Dropdown Produces Inconsistent Results Between Revit versions.
Also fixes DynamoDS/DynamoRevit#2281
I believe this is a more complete version of what you're trying to achieve. @ZiyunShang Let me know how you want to cooperate this task
TODOs:
I have did my manual testing in three basic cases:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner @ZiyunShang
FYIs