| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:12:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=274.482178,conversation_content-fragment;desc="conversation_content fragment";dur=644.493975,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=236.246773,nginx;desc="NGINX";dur=0.444759,glb;desc="GLB";dur=100.730873
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=QE2UWAlL5tDGGKijhJ3VUVTvlmr8Gx%2FlD1B4A%2BCWRAg37X1SHdxocT3UneKJVfd7DCfnibn8WR1p1nMzyBwZCRPL6%2FfaS0ODTeXLg%2BCxd6o6UTaa%2FqMA7YW1mozxbCE5KO%2FoWuF%2B6eNWaJ5EoLpClKFZOnFlYRQ3vFaTgiJ5VWXxVA4Ku%2FzDtb4jRr7QUzyJz1hXmwFPybh4LTb1fpam69caHvz9nHDieVnQtzCvrvXLusRcxSPNYkeR%2Ff5pPHw0WRBFhQEyzBqvxLMWJJtqqw%3D%3D--RwYHXCMi4aqH9IiH--eUX%2F37nRrFn54WlgAUX3IA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1391447141.1753593175; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:55 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:55 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8322:32A0BD:17A8BD:231B89:6885B557
Heterogeneous list update gives infinite loop by reddyashish · Pull Request #9334 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Heterogeneous list update gives infinite loop #9334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @reddyashish, LGTM! |
|
LGTM |
reddyashish
added a commit
that referenced
this pull request
Jan 2, 2019
This reverts commit 67a19a7.
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
Jan 2, 2019
This reverts commit 67a19a7.
QilongTang
pushed a commit
that referenced
this pull request
Jan 2, 2019
mjkkirschner
added a commit
that referenced
this pull request
Jan 3, 2019
mjkkirschner
added a commit
that referenced
this pull request
Jan 3, 2019
QilongTang
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Revert "Heterogeneous list update gives infinite loop (#9334)" This reverts commit 67a19a7. * Obsoleting Surface.Join Node. (#9399) * Add check for invalid cutom node name https://jira.autodesk.com/browse/QNTM-3928 * Removing trailing spaces * Moving the function to utilities class * Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo" This reverts commit 085fb51, reversing changes made to d055de4. * Revert "Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo"" This reverts commit 12538ab. * Adding tests - QNTM-3928 * Comments * Moving the test to NodeViewCustomizationTests.cs * Deleting changes to SerializationTests.cs * Create SerializationTests.cs * Update SerializationTests.cs * moving the test to UtilityTests.ca * Heterogeneous list update gives infinite loop DYN-1198 * Moving the test dyn file * Revert "Moving the test dyn file" This reverts commit d91009e. * Revert "Heterogeneous list update gives infinite loop" This reverts commit e8d7b8a. * making Surface.join node obsolete * Revert "making Surface.join node obsolete" This reverts commit 1458b46. * Obsoleting Surface,Join node. Use Polysurface.ByJoinedSurfaces node instead. * Renaming test file. (cherry picked from commit dee10b6) * Updating the file name related to DYN-1043 (Obsoleting surface.join node) (#9410) * Add check for invalid cutom node name https://jira.autodesk.com/browse/QNTM-3928 * Removing trailing spaces * Moving the function to utilities class * Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo" This reverts commit 085fb51, reversing changes made to d055de4. * Revert "Revert "Merge branch 'master' of https://github.com/DynamoDS/Dynamo"" This reverts commit 12538ab. * Adding tests - QNTM-3928 * Comments * Moving the test to NodeViewCustomizationTests.cs * Deleting changes to SerializationTests.cs * Create SerializationTests.cs * Update SerializationTests.cs * moving the test to UtilityTests.ca * Heterogeneous list update gives infinite loop DYN-1198 * Moving the test dyn file * Revert "Moving the test dyn file" This reverts commit d91009e. * Revert "Heterogeneous list update gives infinite loop" This reverts commit e8d7b8a. * making Surface.join node obsolete * Revert "making Surface.join node obsolete" This reverts commit 1458b46. * Obsoleting Surface,Join node. Use Polysurface.ByJoinedSurfaces node instead. * Renaming test file. * Updating file name (cherry picked from commit 219baa8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
This PR fixes the bug when using a heterogeneous list in computing some results. It runs into an infinite loop and eventually crashes the Dynamo.
There is a redundant 'for' loop on line: 217 in replicator.cs. This will recursively add unnecessary(duplicate) values to the ReducedParams list in there, which can be avoided.
I did some manual testing for other workflows which involved cartesian and zip replication.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap @mjkkirschner @QilongTang
FYIs
@alfarok @ColinDayOrg