You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to address the crash issues that were occurring due to special or non-printable characters in the Custom Node name. https://jira.autodesk.com/browse/QNTM-3928.
@reddyashish Can you do one favor for me and check if there is any file just for testing utilities? Because the place you put the test since does not seem to be the best, the tests there all tests serialization function which I think the test you end up using does not involve serialization
@QilongTang I have moved the test to the NodeViewCustomizationTests.cs file. There is a UtilityTests.cs test suite as well but this looked more appropriate to me, as this had tests checking other functions of PathHelper class. Let me know if you think otherwise.
@reddyashish NodeViewCustomization does not seem proper either, can you move it to Dynamo\test\DynamoCoreTests\UtilityTests.cs? The nodeViewCustomization is for testing a customized NodeModel nodes with radio buttons, drops a 3rd party developer customize.
2.xIssues related to 2.x versions of Dynamo.bugerror/warning/crashIssues mentioning a Dynamo error, warning or crash messageLGTMLooks good to me
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to address the crash issues that were occurring due to special or non-printable characters in the Custom Node name.
https://jira.autodesk.com/browse/QNTM-3928.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner @QilongTang @Racel @alfarok
FYIs
@ColinDayOrg
Error window for no category:

Error window for invalid file name:
