You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I don't see any necessity for the type conversion in this case. This conversion was throwing the error for the input object (DesignScript.Builtin.Dictionary) not being an IConvertible in the first place.
aparajit-pratap
changed the title
Fix unmarshaling of nested DS Dictionary
[DNM] Fix unmarshaling of nested DS Dictionary
Jul 30, 2018
@aparajit-pratap Changes look good to me. Just to confirm the previous behavior still functioned as expected but the node accepting the generic dictionary as an input displayed in a warning state?
Scratch that last question, I see what was going on
Let me know when this is ready for a final look, you mentioned you were adding some additional testing
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix issue with passing nested DesignScript.Builtin Dictionary to ZT node accepting generic Dictionary (Dictionary<string, object>) as argument.
JIRA link: https://jira.autodesk.com/browse/QNTM-4917
Zero touch node definitions used in this example:
The following table shows the different combinations of Dictionary output (rows) being passed into node accepting Dictionary inputs (columns):
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@saintentropy
FYIs
@jnealb