You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mjkkirschner a tolerance of zero basically disables a dynamic surface tolerance chosen by the ASM faceter. A tolerance of -1 enables it while any other positive value considers it as user input. @vkrushelnitskyi so why have you disabled dynamically chosen tolerance value in the case of lower faceting precision? Does this improve performance as well?
@aparajit-pratap I am curious why it has been disabled for the range 8 - 12 only, and also I believe tolerance parameter is based on scale in certain modes - so I am looking for varied inputs/ times to make sure this does not introduce other performance issues with differently scaled geometry.
@aparajit-pratap Yes, this improve performance very much. For example render time of 5000 spheres with default value of "Render preciosion" and -1 value of tolarence take 1 minute 44 sec and 48 sec when tolerance set to 0.
@mjkkirschner because render results in not good with 0 tolerance, so 0 sets only in min range.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request containt changes related to perfomence issue recieved from Alias users.
Changes list:
Result of render 5000 spheres with parameter 8/0 about 5 seconds and with default parameters more than 10 minute.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@aparajit-pratap