You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this PR is to correct a bug in the serialization of nodes using the IsOutput UI. Previously nodes with a return type of integer were being set as Unknown. This issue is tracked with QNTM-4085 and is a dependency of QNTM-3458.
NodeInputData.cs has the same enum types here... The reason it wasn't required is that we type the integer slider with an inthere in IntegerSlider.cs and here in Integer.cs. Does that type need to be something else? The value gets serialized as an Int32
@mjkkirschner... Let's do this. Let me change the enum of supported types on NodeInputData.cs so that we are covered on type checking regardless of what happens on the Slider.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to correct a bug in the serialization of nodes using the IsOutput UI. Previously nodes with a return type of integer were being set as Unknown. This issue is tracked with
QNTM-4085 and is a dependency of QNTM-3458.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @ramramps
FYIs
@nonoesp