| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:32:52 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=302.954661,conversation_content-fragment;desc="conversation_content fragment";dur=794.30593,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=199.887708,nginx;desc="NGINX";dur=0.870612,glb;desc="GLB";dur=100.52851
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=IGL%2BQrKmFmise0PxQZylHOWfnqix2z7pRZo3Zwe9mGEqMf24jfqS8UReEoEPFkHmXOxq5NIVphnEucelWk34XTQ8xoMv0LiNOUUqXdlqMF%2FGu81q6BRS%2BC%2BJKhT0BCoIjwyT0dP1va%2Bof10ee78atpw9Yz3pdL6o5SDp2rL0TOzm4RhOHCJ5cf1J6HFtFL%2FDCixRu1VFNh%2FtjixOmzPOTgAyxSZ8H3GSsJAhiDnzqFzxQM%2FsWpqspyDVPIzGfWUCX%2BRlO2nL71uEGsrpRFyj6w%3D%3D--5pFgu265kGN8et2Q--273KPeKaDQ9ARiqF7kcOkg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.981314158.1753561971; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:32:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:32:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9542:2992:8BE76B:B55DFE:68853B73
Update librarie.min.js & decode search text by alfarok · Pull Request #8776 · DynamoDS/Dynamo · GitHub
alfarok
changed the title
update library.min.js & unescape search text
Update librarie.min.js & unescape search text
Apr 19, 2018
alfarok
changed the title
Update librarie.min.js & unescape search text
Update librarie.min.js & decode search text
Apr 19, 2018
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Update librarie.min.js & decode search text #8776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfarok
changed the title
ramramps
reviewed
Apr 19, 2018
| @@ -40,6 +40,8 @@ public override Stream GetResource(IRequest request, out string extension) | |||
| var pathAndQuery = uri.PathAndQuery; | |||
| var index = url.IndexOf(serviceIdentifier); | |||
| var text = url.Substring(index + serviceIdentifier.Length + 1); | |||
| // unescape query before searching | |||
| text = Uri.UnescapeDataString(text); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, this accepts all special chars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so, here we unescape the encoded URI sent from Librarie.js before searching
alfarok
changed the title
|
@alfarok Can you talk a bit about where we are after this PR, do we have similar search results with 1.3.3? Or we need to do more work to achieve that |
|
@QilongTang librarie.js seems to be very close, if not 1 to 1 with in-canvas results now. This doesn't help the lag or performance. We may want to take a closer look out how the timeout was implemented which creates a delay in displaying the results (much worse in D4R). I don't think it is very efficient and may cause search to appear slower than it actually is. @mjkkirschner had some good ideas around improving this logic.
|
|
@alfarok please run the library tests locally I do not know if @smangarole was able to add them to the self serve CI yet. |
|
|
|
LGTM on these. |
|
@alfarok I think creating a version of search that only runs after the search interaction is idle would increase performance a ton - also whenever search gets invoked, we go back and forth between c# and javascript over IPC, then we go back and forth again via an event, then log to analytics ... |
|
|
alfarok
added a commit
to alfarok/Dynamo
that referenced
this pull request
May 4, 2018
QilongTang
pushed a commit
that referenced
this pull request
May 4, 2018
alfarok
added a commit
to alfarok/Dynamo
that referenced
this pull request
May 7, 2018
alfarok
added a commit
that referenced
this pull request
May 7, 2018
[cherry-pick #8776] Update librarie.min.js & decode search text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
QNTM-4042
Supplemental Librarie.js PR
This PR enables all characters and spaces in search and encodes the string passed from librarie.js to Dynamo where the string is decoded and run through search. Previously, spaces were replaced in searches because the results were not accurately returned due to the string formatting. In a later PR all characters that were not a-z 0-9 were removed from the query string to prevent special characters from crashing librarie. This PR should evade those issues.
Looking forward we may want to consider modifying the search timeout logic to improve response fluidity.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@Racel @jnealb @smangarole