| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:08:59 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=334.907051,conversation_content-fragment;desc="conversation_content fragment";dur=723.54981,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=284.342152,nginx;desc="NGINX";dur=0.869931,glb;desc="GLB";dur=102.497026
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Jwo%2Bp%2Fj9Y4lRf17oUg4TDJs7LgyX18oE2zt43DhmiRgAaxdC37TWJ5hp5fQzM5Ziq9mLSkoXM499cgrIFJCuzAUDM3meK5%2FheK7eTWvD%2BIFFAu8omUBhuMuOE2WSbvCwI3UsafOP42Bl%2FuFKTqnRQasnYbPZsKNrEmaXVzYnOCCP37hQ4aaDxE64XTahJbFrgcT2U%2Bn5%2FV0GJ%2FVecGDBNu7dz3SgwdbLD%2F3jLJBzt7VwAv5KkQy11H53t2UKkysKWvlhfkXo7xB5kOHGAODEiA%3D%3D--74B%2BK3OOZ7%2Bn47%2Be--GC35g7FP0ClQ0yQp20R%2Bhw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.325854770.1753592938; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:08:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:08:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AABA:2CB2E7:ADC7FA:E7B8E4:6885B46A
[Cherry-pick] DYN-9191: RecentFiles bug fix with test fixed by zeusongit · Pull Request #16412 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
[Cherry-pick] DYN-9191: RecentFiles bug fix with test fixed #16412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zeusongit
merged 2 commits into
DynamoDS:RC3.6.0_master
from
zeusongit:cherrypick16394-2
Jul 18, 2025
Merged
[Cherry-pick] DYN-9191: RecentFiles bug fix with test fixed #16412
zeusongit
merged 2 commits into
DynamoDS:RC3.6.0_master
from
zeusongit:cherrypick16394-2
Jul 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2e34aca)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This cherry-pick PR fixes a bug in the recent files functionality that caused errors when removing invalid file paths from the recent files list after the maximum limit was reached. The fix includes proper validation of file paths and safer removal logic.
- Adds path validation to filter out invalid entries when loading preferences
- Implements safer collection removal logic in the UI to prevent index out-of-bounds errors
- Updates test configuration to use a relative path for testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/settings/RecentFilesTest.dyn | New test file containing a basic Dynamo graph for testing recent files functionality |
| test/settings/DynamoSettings-NewSettings.xml | Updates test configuration to reference the new test file with relative path |
| src/DynamoCoreWpf/Controls/StartPage.xaml.cs | Fixes UI collection removal logic to handle non-contiguous removed items safely |
| src/DynamoCore/Configuration/PreferenceSettings.cs | Adds validation to filter invalid file paths when loading preferences |
This was referenced Jul 18, 2025
aparajit-pratap
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Cherry-pick of #16394 and #16411 to RC3.6.0_master
Purpose
When changing recent files cache, in case when max recent files has been reached, removing the last item from the collection would throw an error, if invalid paths exist.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Adds logic to refresh the recent file list when removed items are not contiguous, ensuring the UI stays in sync with the underlying data.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of