| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 10:15:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=320.176746,conversation_content-fragment;desc="conversation_content fragment";dur=801.865007,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=259.06246,nginx;desc="NGINX";dur=1.536068,glb;desc="GLB";dur=101.020167
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZEH4cHqM6FQqePaUJmmKO%2Bek4%2Bmoga3LREgYIhsKk%2BUIPn9bzX1DJoS6rjFMS1uJsp6B4XkwnZN1BfgmppcswwHWum9LXYjlQcgPNTuXaytPbKylH7qnNZbeY2mkfmgQWn7oBeFPUka6AP99bTphwjKEpkgoW%2BBfUSnYwhBbIYlUwrZ5Opm8vbBMbyEXbWBLJdYC8EBtjhlPozZKiS49ky8JSbXCPKNtYm09QW7tWZbLWiGiE%2Bl2Jpkq9dtBij6COYBkqS%2BGkwtn9A%2BCI5UHEQ%3D%3D--YFi4B12JyDuSsaKW--jZhz7ODXzELfG1xIUFoW8g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.960495293.1753611335; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:15:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:15:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A25E:1A1F38:D33CD0:116DEE2:6885FC47
[DYN-8893] - Double click on group to add cbn by ivaylo-matov · Pull Request #16383 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
[DYN-8893] - Double click on group to add cbn #16383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zeusongit
merged 2 commits into
DynamoDS:master
from
ivaylo-matov:DYN-8893-Double-click-on-group-to-add-cnb
Jul 15, 2025
Merged
[DYN-8893] - Double click on group to add cbn #16383
zeusongit
merged 2 commits into
DynamoDS:master
from
ivaylo-matov:DYN-8893-Double-click-on-group-to-add-cnb
Jul 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8893
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restores double-click functionality on annotation groups to add a CodeBlockNode and adds a corresponding unit test.
- Subscribes to
PreviewMouseDoubleClickinAnnotationView.xaml.csand implementsOnAnnotationDoubleClicklogic. - Adds a test
DoubleClickOnGroupAddsCodeBlockNodeto verify the new behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/DynamoCoreWpfTests/AnnotationViewTests.cs | Added test for double-click on group adding a CBN. |
| src/DynamoCoreWpf/Views/Core/AnnotationView.xaml.cs | Subscribes/unsubscribes double-click event and handler. |
Comments suppressed due to low confidence (1)
test/DynamoCoreWpfTests/AnnotationViewTests.cs:184
- After verifying the node count, add an assertion to check that the newly added node is of type
CodeBlockNodeModel, ensuring the correct node type was created.
Assert.AreEqual(3, group1.Nodes.Count(), "Expected group to have 3 nodes after double click.");
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
reddyashish
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Small PR related to DYN-8893 and this tread.
This PR restores the changes to AnnotationView.xaml.cs that allow double-clicking on a group to add a CodeBlockNode to it. These changes were previously submitted in #16334 but are not present in the current master branch.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Double-clicking on a group adds a code block node to it.
Reviewers
@DynamoDS/eidos
@jasonstratton
@zeusongit
FYIs
@dnenov
@achintyabhat