| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:12:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=369.697805,conversation_content-fragment;desc="conversation_content fragment";dur=754.323465,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=292.125986,nginx;desc="NGINX";dur=0.849894,glb;desc="GLB";dur=100.267871
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=2%2F0QlktCmRTKlaVaiaiePtgIyqdB7CNoW%2BVuktwTINahdZLp7dm0x5f2XDV%2BIV4tPhzTTgNxD1bcJO%2FUoQLLbiFgYCw5MbN1%2BWUXizezo0MMDsptjxP1ptCAh15NPIJ%2FcOEq7uIWHpiwAaGZfC8YloocJXBLa1GRPL60cRJJYUu9UFh8uSQCImryVgyc63dVOsv9VJZ9VxBiTw2kh%2FdR9AhoWIGufehsJjfuJg4duXQ%2F73vCZlzzxIELU0DN5a8C2yBUDbSZnR8v1SII838kZQ%3D%3D--gQEnXYBVfT28glE1--WzV0%2BTg0SsH0wOizKQFoyg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1969707997.1753593169; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8294:93466:17EDCF:23613A:6885B551
DYN-9028: force recalculate formula fields by dnenov · Pull Request #16352 · DynamoDS/Dynamo · GitHub
github-actions
bot
changed the title
force recalculate formula fields
DYN-9028: force recalculate formula fields
Jul 8, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-9028: force recalculate formula fields #16352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zeusongit
merged 2 commits into
DynamoDS:master
from
dnenov:DYN-9028-opencml-recalculate-formulas
Jul 9, 2025
Merged
DYN-9028: force recalculate formula fields #16352
zeusongit
merged 2 commits into
DynamoDS:master
from
dnenov:DYN-9028-opencml-recalculate-formulas
Jul 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- requests full calculation when opening the excel file after writing it with Dynamo OpenXML
stylesheet.NumberingFormats can be null, this prevents from null exception to happen
github-actions
bot
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9028
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that Excel formula fields are recalculated when the file is opened and adds a null‐safe check for numbering formats when formatting cell values.
- Forces full recalculation of formulas on load
- Adds null check around
stylesheet.NumberingFormatsto avoid NRE - Returns unformatted value string if no numbering format is found
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| OpenXmlHelper.cs (Write method) | Appends CalculationProperties and sets FullCalculationOnLoad = true to force formula recalculation |
| OpenXmlHelper.cs (GetCellValue block) | Uses null‐safe access (?.ElementAt) on NumberingFormats and early returns unformatted string when missing |
jasonstratton
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
zeusongit
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
This PR follows the issue discussed here: https://jira.autodesk.com/browse/DYN-9028 - Formulas breaking (not recomputing) after exporting new data using OpenXML node to an existing Excel with Formula
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
stylesheet.NumberingFormatsisnullReviewers
@jasonstratton
@zeusongit
@achintyabhat
FYIs
@reddyashish