| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:33:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=487.900126,conversation_content-fragment;desc="conversation_content fragment";dur=1296.785724,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=333.152076,nginx;desc="NGINX";dur=1.379039,glb;desc="GLB";dur=100.780094
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=FNXGJSeq38fH6vJL58wAUnp36XtebNPcKyGnOKwbIWSTvqy7ldNEX47RJAGYT0uA%2BW%2F0sQ3F0jIPy3FLJZCZXLnpPcb8xEEEl%2BLhuhiYlQr%2Bx%2FpfbpJzJseB1xFD1qBWsMer0PY90WO8Ea%2Bd6LhtLXbwfUB3S3EgJmAY1nAHT%2B91zMyS0acFpHAFBwCc47KOMGekXR8kmI8SrZd5JEVDCWe6QTxFHelot3LWPiXOikMvmqvVJms%2B%2BWf6OH0jxKPcyhprUNQvWSAKJAYhALRJyw%3D%3D--PqFZ%2FJ41XqrUcACE--%2Fgmavzb9rzsmrHk8a7MPrg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.509781328.1753562011; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E650:1A1F38:8E3A59:B7B7AF:68853B9B
DYN-9089: autofocus search box by chubakueno · Pull Request #16336 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-9089: autofocus search box #16336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9089
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds autofocus behavior and improved dropdown handling to the node autocomplete bar, makes the search box sticky at the top, and prevents duplicate cluster insertions.
- Auto-focuses and auto-selects the first filtered item when the search input or dropdown state changes
- Binds dropdown open state to the viewmodel and refactors view events to trigger focus
- Updates theme XAML to keep the search box visible at the top and adjust scroll margins
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml.cs | Adds OnRefocusSearchBox handler and wires ViewModel event |
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml | Binds IsDropDownOpen to viewmodel |
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Implements IsDropDownOpen property and RefocusSearchBox event; sets first item on search change; prevents duplicate clusters |
| src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml | Moves scroll viewer margin to keep search slot sticky |
Comments suppressed due to low confidence (1)
src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml.cs:38
- [nitpick] The method name
OnRefocusSearchboxdoesn't follow PascalCase for 'Box'. Rename it toOnRefocusSearchBoxto match .NET naming conventions and the event name.
private void OnRefocusSearchbox()
src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml
Outdated
Show resolved
Hide resolved
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
Outdated
Show resolved
Hide resolved
…arViewModel.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…w.xaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
BogdanZavu
reviewed
Jul 3, 2025
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs
Outdated
Show resolved
Hide resolved
BogdanZavu
reviewed
Jul 3, 2025
| @@ -413,7 +440,8 @@ internal void ResetAutoCompleteSearchViewState() | |||
| FilteredResults = new List<NodeSearchElementViewModel>(); | |||
| FilteredHighConfidenceResults = new List<NodeSearchElementViewModel>(); | |||
| FilteredLowConfidenceResults = new List<NodeSearchElementViewModel>(); | |||
| SearchInput = string.Empty; | |||
| SearchInput = string.Empty; | |||
| lastAddedCluster = null; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps set this to null when we are closing the flyout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure if we should clean up some set of variables on close and some (possibly overlapping) set of variables on open. Ideally we should call the whole function on open and close but for the moment i think its ok to move the least code now that we're close to release.
|
This works really nice! Some minor comments , feel free to address as you see fit. LGTM! |
BogdanZavu
approved these changes
Jul 3, 2025
chubakueno
added a commit
to chubakueno/Dynamo
that referenced
this pull request
Jul 8, 2025
This reverts commit 7fb748b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Autofocus search box, make search box sticky on top and autoselect first filtered element on search box change.
2025-07-01.20-23-25.mp4
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Autofocus search box, make search box sticky on top and autoselect first filtered element on search box change.
Reviewers
@johnpierson
@BogdanZavu
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of