| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:33:31 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=421.923223,conversation_content-fragment;desc="conversation_content fragment";dur=1118.856992,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=445.960894,nginx;desc="NGINX";dur=0.895602,glb;desc="GLB";dur=101.209682
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ldVoU2QTZvPXkKaaYBPLZze2a0bDXIIfdLaShCe9ZNxYe6tnnSL5J6nSjdtwskwgDSLDgP0Jw47eSsyEDqDhcqKg5Nu0ZsLkBxezgY6crEFEuBv7vV1RKA84bGXvRRhzb%2FAS8oQffaurq0shsX72EM8BWR5Wv4oHcLW7RIf5BdkOwRM2PE9KIcKmXuK0%2FGc0KoVggH4tSRRdEBZVWMLKByeOvk9kfcjCGvArJs%2FWlSR0TIMQMp0LM2Vj%2Fcdrj6K75rg0xgZ1D2gygSZVAJhGLA%3D%3D--Ip2G55K%2FLgZYr6vm--%2FMoNLeFbRNhDElKHhRy47w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.192597359.1753562010; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:30 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:30 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E632:1A1F38:8E3A32:B7B77E:68853B9A
DYN-8656: connector pins reconnect undo fix by dnenov · Pull Request #16331 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-8656: connector pins reconnect undo fix #16331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zeusongit
merged 4 commits into
DynamoDS:master
from
dnenov:DYN-8656-connection-pins-undo
Jul 9, 2025
Merged
DYN-8656: connector pins reconnect undo fix #16331
zeusongit
merged 4 commits into
DynamoDS:master
from
dnenov:DYN-8656-connection-pins-undo
Jul 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed the flow of the shift-reconnect routine - first of all, added the connection deletion as part of the recordanddelete logic - secondly, now recording the pins as part of the saved Models to be group when the new stack of wires is created. The order of savedModels matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8656
- added test - now raises undoredo event when triggering the command
zeusongit
reviewed
Jun 30, 2025
zeusongit
reviewed
Jun 30, 2025
- increase the popup await to allow for the system to initialize the popup window - test fix
|
I don't see any failing tests, but I am not sure if there are things to be resolved on this one.
|
I'm not sure why the tests are failing, but I thought there might be an issue with other PR as well. @zeusongit, is there a build issue currently? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that connector pins are correctly handled in the undo/redo stack when reconnecting wires, raises the undo/redo UI state for connection commands, and adds tests to validate the new behavior.
- Record and delete connector pins in the undo/redo workflow for reconnections
- Trigger the undo/redo UI button when connection commands complete
- Add and update tests (and the
.dyntest graph) to cover connector-pin reconnection scenarios
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/UI/ConnectorPinTests.dyn | Expanded the test graph with a new code block node and updated connector visibility schema |
| test/DynamoCoreWpfTests/ConnectorViewModelTests.cs | Added CanUndoShiftReconnectionWithConnectorPin test |
| test/DynamoCoreWpf2Tests/ViewExtensions/NotificationsExtensionTests.cs | Increased popup-wait timeout in UI test |
| src/DynamoCoreWpf/Commands/DynamoCommands.cs | Added RaiseCanExecuteUndoRedo() on MakeConnectionCommand completion |
| src/DynamoCore/Models/DynamoModelCommands.cs | Removed manual connector deletes in BeginShiftReconnections |
| src/DynamoCore/Graph/Workspaces/UndoRedo.cs | Enhanced RecordAndDeleteModels/SaveAndDeleteModels to include connector pins |
Comments suppressed due to low confidence (2)
test/UI/ConnectorPinTests.dyn:88
- Using the property
IsHiddeninstead of the expectedIsVisiblemay not be recognized by the Dynamo graph loader; please revert toIsVisibleor confirm thatIsHiddenis supported in the.dynschema.
"IsHidden": "False"
src/DynamoCore/Graph/Workspaces/UndoRedo.cs:6
- The
Autodesk.DesignScript.Geometryusing directive is not used in this file and can be removed to keep imports clean.
using Autodesk.DesignScript.Geometry;
| @@ -39,7 +39,7 @@ public void PressNotificationButtonAndShowPopup() | |||
| return notificationUI != null; | |||
| } | |||
| return false; | |||
| }, 180); | |||
| }, 300); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider extracting the hardcoded timeout 300 into a named constant or configuration value to clarify its purpose and make future adjustments easier.
Suggested change
| }, 300); | |
| }, NotificationPopupTimeout); |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
Yes, there have been multiple issues today |
One test failure, but unrelated, merging |
zeusongit
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Addresses this jira thread: https://jira.autodesk.com/browse/DYN-8656
Previously, rehosting Node connectors (wires) would cause Pins to be 'lost' in the undo/redo stack. This PR fixes that and now Pins will correctly be recreated when undoing changes.
As an additional change, triggering this behavior will now correctly raise undo/redo changes activating the
undobutton.Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@jasonstratton
@reddyashish
@zeusongit
FYIs
@achintyabhat