| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 14:06:28 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=394.997059,conversation_content-fragment;desc="conversation_content fragment";dur=709.725011,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=267.403035,nginx;desc="NGINX";dur=1.10873,glb;desc="GLB";dur=100.814831
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=fMW73T6vQpvySnvBcYBpo7lMVXE3NTbTBHCRUFtA%2FB3rWYfjeDMZsXGOXxaVa9uj8AUoKXBuG8WuFHBwn7SVIQu4Z9j3r9J3tABqi6dhnjO5fptz5X4OQ9%2FM8bTxnKZYUPYpHDRGLSwHFs8gbbBStKjEtVo5g8ALVFc6qB%2FPoVQxEuRRnpGcEdowkdxBK3U%2B27fDjbYv3ceGMvb0qhaMT0xCZ3oCgjVKTtiAnf0gf8VaDygXrzs44%2FkSXycpX0QUY3NLLuw64kct1YSYrXNAPw%3D%3D--98ccbpOZ9oOTTRqu--FnRv07mRUOnVdhKnYcmPcg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1448902952.1753625187; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 14:06:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 14:06:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DC3C:1A1F38:EEE009:139CFD1:68863263
DYN-8307: Remove unused code for Port cursor by zeusongit · Pull Request #16311 · DynamoDS/Dynamo · GitHub
github-actions
bot
changed the title
Remove unused code for Port cursor
DYN-8307: Remove unused code for Port cursor
Jun 18, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-8307: Remove unused code for Port cursor #16311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes legacy port-hover cursor logic to streamline mouse movement handling and improve performance.
- Deletes the idle-state hit-test block that set the cursor when hovering over input ports.
- Removes associated helper methods (
PortFromHitTestResult,ElementUnderMouseCursor,DirectHitTestCallback) and related cursor-setting code.
Comments suppressed due to low confidence (2)
src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs:873
- [nitpick] With the port-hover cursor logic removed, it would be helpful to add tests verifying that the cursor state remains correct during various mouse movements and workspace states to prevent regressions.
// If selection is going to be dragged and ctrl is pressed.
| PortViewModel pvm = PortFromHitTestResult(dependencyObject); | ||
|
|
||
| if (null != pvm && (pvm.PortType == PortType.Input)) | ||
| this.Cursor = CursorLibrary.GetCursor(CursorSet.ArcSelect); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this cursor look like? Is there a png (image file) resource for the cursor that also needs to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it looks like:
I tried going back to 2.17, 2.15 and still could not see any change in the cursor though, atleast not on hover.
aparajit-pratap
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Based on the Reope PR: #15825
See original PR's description for a detailed summary.
TLDR; Removing some code from MouseMove event which used to trigger when mouse hover over the input port, at which point the cursor should have been changed to
CursorSet.ArcSelect. But this have not been working since Notes were introduced (May 2023). IMO it is better to go away with it and gain some performance instead.I tried to quantify the gain but it is hard, I tried to capture the amount of processing time spent inside the code while simply hovering over a huge graph, for a difference in CPU usage you can look at the screenshots on the original PR.
(I did see minor gains when selecting nodes in the workspace after this fix)
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Remove unused code for Port cursor
Reviewers